From patchwork Fri Sep 30 17:07:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Friesen X-Patchwork-Id: 117169 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2BB47B6F69 for ; Sat, 1 Oct 2011 03:10:06 +1000 (EST) Received: from localhost ([::1]:50647 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9gb2-0008Ih-OL for incoming@patchwork.ozlabs.org; Fri, 30 Sep 2011 13:10:00 -0400 Received: from eggs.gnu.org ([140.186.70.92]:39081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9gax-0008IO-64 for qemu-devel@nongnu.org; Fri, 30 Sep 2011 13:09:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9gav-00065H-Lp for qemu-devel@nongnu.org; Fri, 30 Sep 2011 13:09:55 -0400 Received: from exprod7og112.obsmtp.com ([64.18.2.177]:55840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9gav-00061I-ER for qemu-devel@nongnu.org; Fri, 30 Sep 2011 13:09:53 -0400 Received: from mail.genband.com ([63.149.188.88]) (using TLSv1) by exprod7ob112.postini.com ([64.18.6.12]) with SMTP ID DSNKToX31sSaebAsfezPBAtMihJCtqZJMyfF@postini.com; Fri, 30 Sep 2011 10:09:53 PDT Received: from gbausmail.genband.com ([172.16.21.62]) by mail.genband.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 30 Sep 2011 12:07:15 -0500 Received: from [1.220.38.92] ([1.220.38.92]) by gbausmail.genband.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 30 Sep 2011 12:07:14 -0500 Message-ID: <4E85F741.2050100@genband.com> Date: Fri, 30 Sep 2011 11:07:13 -0600 From: Chris Friesen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110906 Fedora/3.1.14-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.14 MIME-Version: 1.0 To: kvm@vger.kernel.org, qemu-devel@nongnu.org, Avi Kivity , Jan Kiszka X-OriginalArrivalTime: 30 Sep 2011 17:07:14.0949 (UTC) FILETIME=[66DB9B50:01CC7F93] X-TM-AS-Product-Ver: SMEX-8.0.0.4160-6.500.1024-18418.000 X-TM-AS-Result: No--11.955300-5.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 64.18.2.177 Subject: [Qemu-devel] [BUG] need to export variables in config.mak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We've been playing a bit with kvm-kmod-3.0b. We use a cross compile environment, and one of my coworkers noticed that the variables in config.mak weren't actually exported and so didn't actually have any effect. I think something like the following patch is required. Thanks, Chris Friesen Index: kvm-kmod-3.0b/configure =================================================================== --- kvm-kmod-3.0b.orig/configure 2011-09-27 15:12:08.000009000 -0500 +++ kvm-kmod-3.0b/configure 2011-09-27 15:11:59.001566000 -0500 @@ -168,24 +168,24 @@ fi rm -f include/asm include-compat/asm mkdir -p include ln -sf asm-"$karch" include/asm ln -sf asm-"$karch" include-compat/asm cat < config.mak -ARCH=$arch -PROCESSOR=$processor -PREFIX=$prefix -KERNELDIR=$kerneldir -KERNELSOURCEDIR=$kernelsourcedir -KERNELVERSION=$kernel_version_str -CROSS_COMPILE=$cross_prefix -CC=$cross_prefix$cc -LD=$cross_prefix$ld -OBJCOPY=$cross_prefix$objcopy -AR=$cross_prefix$ar -KVM_VERSION=$(kvm_version) +export ARCH=$arch +export PROCESSOR=$processor +export PREFIX=$prefix +export KERNELDIR=$kerneldir +export KERNELSOURCEDIR=$kernelsourcedir +export KERNELVERSION=$kernel_version_str +export CROSS_COMPILE=$cross_prefix +export CC=$cross_prefix$cc +export LD=$cross_prefix$ld +export OBJCOPY=$cross_prefix$objcopy +export AR=$cross_prefix$ar +export KVM_VERSION=$(kvm_version) EOF cat < kvm-kmod-config.h #define KERNEL_EXTRAVERSION $kernel_extraversion $config_fedora_kernel EOF