From patchwork Wed Jul 20 17:41:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 105994 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 54F13B6F74 for ; Thu, 21 Jul 2011 17:02:34 +1000 (EST) Received: from localhost ([::1]:44869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjdu1-000622-DS for incoming@patchwork.ozlabs.org; Wed, 20 Jul 2011 17:01:57 -0400 Received: from eggs.gnu.org ([140.186.70.92]:57277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjali-0002AZ-Aw for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:41:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qjalf-0008AS-Im for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:41:09 -0400 Received: from david.siemens.de ([192.35.17.14]:31219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjale-00089y-RX for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:41:07 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id p6KHf38B010699; Wed, 20 Jul 2011 19:41:03 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id p6KHf2mA016012; Wed, 20 Jul 2011 19:41:03 +0200 Message-ID: <4E27132E.6080504@siemens.com> Date: Wed, 20 Jul 2011 19:41:02 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Avi Kivity References: <1311180636-17012-1-git-send-email-avi@redhat.com> In-Reply-To: <1311180636-17012-1-git-send-email-avi@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.14 Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: Re: [Qemu-devel] [RFC v5 00/86] Memory API X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 2011-07-20 18:49, Avi Kivity wrote: > New in this version: > - more mindless conversions; I believe there are no longer any destructive > operations in the tree (IO_MEM_UNASSIGNED) > - fix memory map generation bug (patch 13) > - proper 440FX PAM/SMRAM and PCI holes > This on top fixes standard VGA dirty logging: Cirrus is still broken (test case: grub), debugging ATM. Jan diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index e367052..8e8b24c 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -2944,8 +2944,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) memory_region_add_subregion(&s->pci_bar, 0x1000000, &s->cirrus_linear_bitblt_io); - vga_dirty_log_start(&s->vga); - /* setup memory space */ /* memory #0 LFB */ /* memory #1 memory-mapped I/O */ diff --git a/hw/vga.c b/hw/vga.c index 5a78b71..8acc545 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2195,6 +2195,7 @@ void vga_common_init(VGACommonState *s, int vga_ram_size) s->update_retrace_info = vga_precise_update_retrace_info; break; } + vga_dirty_log_start(s); } /* used by both ISA and PCI */