| Message ID | 4D682B29.5070001@mail.berlios.de |
|---|---|
| State | Accepted |
| Headers | show |
On 02/25/2011 04:20 PM, Stefan Weil wrote: > This patch was already sent on 2011-01-24: > > Hopefully all functions with printf like arguments now use format > checking. > > This was tested with default build configuration on linux > and windows hosts (including some cross compilations), > so chances are good that there remain few (if any) functions > without format checking. > > Therefore the last comment in HACKING is no longer valid but misleading. > > Cc: Blue Swirl <blauwirbel@gmail.com> > Signed-off-by: Stefan Weil <weil@mail.berlios.de> Applied. Thanks. Regards, Anthony Liguori > --- > HACKING | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/HACKING b/HACKING > index 6ba9d7e..3af53fd 100644 > --- a/HACKING > +++ b/HACKING > @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype. > This makes it so gcc's -Wformat and -Wformat-security options can do > their jobs and cross-check format strings with the number and types > of arguments. > - > -Currently many functions in QEMU are not following this rule but > -patches to add the attribute would be very much appreciated.
diff --git a/HACKING b/HACKING index 6ba9d7e..3af53fd 100644 --- a/HACKING +++ b/HACKING @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype. This makes it so gcc's -Wformat and -Wformat-security options can do their jobs and cross-check format strings with the number and types of arguments. - -Currently many functions in QEMU are not following this rule but -patches to add the attribute would be very much appreciated.
This patch was already sent on 2011-01-24: Hopefully all functions with printf like arguments now use format checking. This was tested with default build configuration on linux and windows hosts (including some cross compilations), so chances are good that there remain few (if any) functions without format checking. Therefore the last comment in HACKING is no longer valid but misleading. Cc: Blue Swirl <blauwirbel@gmail.com> Signed-off-by: Stefan Weil <weil@mail.berlios.de> --- HACKING | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)