From patchwork Thu Feb 10 09:51:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 82586 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 104E1B70E3 for ; Thu, 10 Feb 2011 20:53:44 +1100 (EST) Received: from localhost ([127.0.0.1]:45403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnTDR-0006GG-33 for incoming@patchwork.ozlabs.org; Thu, 10 Feb 2011 04:53:33 -0500 Received: from [140.186.70.92] (port=52030 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnTBS-0005cH-QQ for qemu-devel@nongnu.org; Thu, 10 Feb 2011 04:51:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnTBI-0004RA-Ii for qemu-devel@nongnu.org; Thu, 10 Feb 2011 04:51:21 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:51796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PnTBI-0004Qx-7y for qemu-devel@nongnu.org; Thu, 10 Feb 2011 04:51:20 -0500 Received: by wwi18 with SMTP id 18so1089612wwi.10 for ; Thu, 10 Feb 2011 01:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=0p8yjg/goDXofi6VD2otNacN+qwwqjmcWFTAUGpkh/c=; b=DjpM4ZB3b+MMWaaMa6cPiHWPx7f0Vi0NsLVMcFYiMog/CjzILq0TeDykPdmnyMQUoV KkcQUUL3QyDrP/aJmp6n+I+Z1gD9TvqMLU8iowjbxW+aSFXGsAKBcOm+Ls87BuIKN2lc vHX372JPsZhQmWQb+3su47b4JFetvJIoIx6v0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=MubwqPysZ1qO19NMBzwGiDLiCUnxdzQwJODGDbEdG1aagCkZufHDg7UEHm04gIFqi2 htuQxjQjKkbWL1CaPrlLPR56suzSUnqyGFu5GP2AAljssHRi3+zvAoSiqcrJv8TBnfoc nKwzKf+v+K6nPNaSOqrAsN+M6RrB+KQXUOCxw= Received: by 10.216.24.207 with SMTP id x57mr17579679wex.89.1297331478968; Thu, 10 Feb 2011 01:51:18 -0800 (PST) Received: from yakj.usersys.redhat.com (93-34-149-100.ip50.fastwebnet.it [93.34.149.100]) by mx.google.com with ESMTPS id n78sm643020weq.27.2011.02.10.01.51.17 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 10 Feb 2011 01:51:18 -0800 (PST) Message-ID: <4D53B514.7050605@redhat.com> Date: Thu, 10 Feb 2011 10:51:16 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 MIME-Version: 1.0 To: Pavel Dovgaluk References: <4560.09833510524$1294992458@news.gmane.org> In-Reply-To: <4560.09833510524$1294992458@news.gmane.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.53 Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org > diff --git a/Makefile.objs b/Makefile.objs > index 4a1eaa1..ee9f190 100755 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -269,10 +269,10 @@ vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS) > vl.o: QEMU_CFLAGS+=$(SDL_CFLAGS) > -vl.o: qemu-options.def > +vl.o: ../qemu-options.def > os-posix.o: qemu-options.def > os-win32.o: qemu-options.def > -qemu-options.def: $(SRC_PATH)/qemu-options.hx > +%qemu-options.def: $(SRC_PATH)/qemu-options.hx > $(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@," GEN $(TARGET_DIR)$@") This is wrong, I think the problem is that you are missing a vpath directive. Does this help? Paolo diff --git a/rules.mak b/rules.mak index ed59c9e..6f753ae 100644 --- a/rules.mak +++ b/rules.mak @@ -39,7 +39,7 @@ quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1)) cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \ >/dev/null 2>&1 && echo OK), $2, $3) -VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi +VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi %.def set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1))) # find-in-path