From patchwork Mon Dec 27 14:57:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 76790 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DE157B70DA for ; Tue, 28 Dec 2010 02:01:05 +1100 (EST) Received: from localhost ([127.0.0.1]:38038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXEZJ-0008TM-E3 for incoming@patchwork.ozlabs.org; Mon, 27 Dec 2010 10:01:01 -0500 Received: from [140.186.70.92] (port=38367 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXEY0-0008SJ-9b for qemu-devel@nongnu.org; Mon, 27 Dec 2010 09:59:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXEXz-0005Nh-4C for qemu-devel@nongnu.org; Mon, 27 Dec 2010 09:59:40 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:41209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXEXy-0005NK-Od for qemu-devel@nongnu.org; Mon, 27 Dec 2010 09:59:39 -0500 Received: from smtp05.web.de ( [172.20.4.166]) by fmmailgate03.web.de (Postfix) with ESMTP id E4A8C182F9BFE; Mon, 27 Dec 2010 15:57:37 +0100 (CET) Received: from [178.3.214.57] (helo=mchn199C.mchp.siemens.de) by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1PXEW1-0005UW-00; Mon, 27 Dec 2010 15:57:37 +0100 Message-ID: <4D18A95F.2010601@web.de> Date: Mon, 27 Dec 2010 15:57:35 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Avi Kivity , Marcelo Tosatti X-Enigmail-Version: 1.1.2 X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1/+KulkGDn3PwSZYzOIaDq/DkbESmt5KocBC2m6 AfXoyjFXYrcPseUAQDauydHKT/0/f8WkiFWHBtJZfYFhAZnur1 PNYbicbsc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: qemu-devel , kvm Subject: [Qemu-devel] [PATCH] kvm: x86: Remove obsolet SS.RPL/DPL aligment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka This seems to date back to the days KVM didn't support real mode. The check is no longer needed and, even worse, is corrupting the guest state in case SS.RPL != DPL. Signed-off-by: Jan Kiszka --- target-i386/kvm.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index b3d7c54..85edacc 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -780,13 +780,6 @@ static int kvm_put_sregs(CPUState *env) set_seg(&sregs.fs, &env->segs[R_FS]); set_seg(&sregs.gs, &env->segs[R_GS]); set_seg(&sregs.ss, &env->segs[R_SS]); - - if (env->cr[0] & CR0_PE_MASK) { - /* force ss cpl to cs cpl */ - sregs.ss.selector = (sregs.ss.selector & ~3) | - (sregs.cs.selector & 3); - sregs.ss.dpl = sregs.ss.selector & 3; - } } set_seg(&sregs.tr, &env->tr);