From patchwork Thu May 13 13:09:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 52482 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E0BAAB7E24 for ; Thu, 13 May 2010 23:10:58 +1000 (EST) Received: from localhost ([127.0.0.1]:49043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCYBi-00088T-LA for incoming@patchwork.ozlabs.org; Thu, 13 May 2010 09:10:54 -0400 Received: from [140.186.70.92] (port=57507 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCYB3-00088O-50 for qemu-devel@nongnu.org; Thu, 13 May 2010 09:10:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCYAy-0002LQ-42 for qemu-devel@nongnu.org; Thu, 13 May 2010 09:10:13 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:37204) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCYAx-0002LE-UF for qemu-devel@nongnu.org; Thu, 13 May 2010 09:10:08 -0400 Received: from smtp05.web.de ( [172.20.4.166]) by fmmailgate02.web.de (Postfix) with ESMTP id B01581608BBCE for ; Thu, 13 May 2010 15:10:06 +0200 (CEST) Received: from [88.64.22.236] (helo=[192.168.1.10]) by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #4) id 1OCYAw-0006B4-00 for qemu-devel@nongnu.org; Thu, 13 May 2010 15:10:06 +0200 Message-ID: <4BEBFA26.50300@web.de> Date: Thu, 13 May 2010 15:09:58 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: qemu-devel X-Enigmail-Version: 0.95.7 X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1/TgzaOL0fQJ/OY7KDvb7/d9gW/2cLHAON1FBLF EB2vRhfWEa7CLo/ow3En+5R8ZjTnC7zWroctfnAkySJ4aB4QVH UpEb0zVTI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Subject: [Qemu-devel] [PATCH] musicpal: Drop redundant reset call X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Reset is now triggered after init, no need for explicit calls anymore. Signed-off-by: Jan Kiszka --- hw/musicpal.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index ebd933e..d44c5a0 100644 --- a/hw/musicpal.c +++ b/hw/musicpal.c @@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev) musicpal_gpio_writefn, s); sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype); - musicpal_gpio_reset(&dev->qdev); - qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out)); qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);