From patchwork Wed Feb 24 06:32:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Kilgour X-Patchwork-Id: 46113 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0C274B7CB6 for ; Wed, 24 Feb 2010 17:33:14 +1100 (EST) Received: from localhost ([127.0.0.1]:41265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NkAo3-00071T-6n for incoming@patchwork.ozlabs.org; Wed, 24 Feb 2010 01:33:11 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NkAnF-00071N-EZ for qemu-devel@nongnu.org; Wed, 24 Feb 2010 01:32:21 -0500 Received: from [199.232.76.173] (port=36311 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NkAnD-00071F-SI for qemu-devel@nongnu.org; Wed, 24 Feb 2010 01:32:19 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NkAnB-0006B9-TJ for qemu-devel@nongnu.org; Wed, 24 Feb 2010 01:32:19 -0500 Received: from mx6-3.i-mecca.net ([65.39.179.42]:58673) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NkAnB-0006Ah-Je for qemu-devel@nongnu.org; Wed, 24 Feb 2010 01:32:17 -0500 Received: from ns6.i-mecca.net (ns6 [127.0.0.1]) by ns6.i-mecca.net (Postfix) with ESMTP id B17397BCE10; Wed, 24 Feb 2010 01:32:15 -0500 (EST) Received: from kilgour.homelinux.com (unknown [97.107.180.199]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ns6.i-mecca.net (Postfix) with ESMTPSA id 29D907BCE10; Wed, 24 Feb 2010 01:32:15 -0500 (EST) Message-ID: <4B84C7EE.4050303@whiterocker.com> Date: Tue, 23 Feb 2010 22:32:14 -0800 From: Chris Kilgour User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc11 Thunderbird/3.0.1 MIME-Version: 1.0 To: Anthony Liguori References: <4B78A904.9020700@whiterocker.com> <4B7F0390.1030206@codemonkey.ws> In-Reply-To: <4B7F0390.1030206@codemonkey.ws> X-detected-operating-system: by monty-python.gnu.org: Windows 98 (1) Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] pcnet APROMWE bit location (retry) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2. Signed-off-by: Christopher Kilgour diff --git a/hw/pcnet.c b/hw/pcnet.c index 44b5b31..f889898 100644 --- a/hw/pcnet.c +++ b/hw/pcnet.c @@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque, uint32_t addr, uint32_t val) printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val); #endif /* Check APROMWE bit to enable write access */ - if (pcnet_bcr_readw(s,2) & 0x80) + if (pcnet_bcr_readw(s,2) & 0x100) s->prom[addr & 15] = val; }