Message ID | 4B6EA3F1.5000405@web.de |
---|---|
State | New |
Headers | show |
On Sun, Feb 07, 2010 at 12:28:49PM +0100, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote: > >> This version addresses the feedback on v2, namely: > >> - assert(<vm stopped> || <current thread == env->thread>) on low-level > >> load/save registers > >> - fixed mpstate initialization > >> > > With those patched, doing "info cpus" in monitor kill the guest, which, > > unfortunately, means that reworked VCPU state writeback is still not so > > easy to use correctly. > > > > Regression of patch 12 ("qemu-kvm: Use upstream kvm_vcpu_dirty"), will > be fixed in v3. > Looks better now indeed. Thanks. -- Gleb.
diff --git a/qemu-kvm.c b/qemu-kvm.c index 6a72b89..72c2ca0 100644 --- a/qemu-kvm.c +++ b/qemu-kvm.c @@ -1532,13 +1532,13 @@ static void do_kvm_cpu_synchronize_state(void *_env) CPUState *env = _env; kvm_arch_save_regs(env); + env->kvm_vcpu_dirty = 1; } void kvm_cpu_synchronize_state(CPUState *env) { if (!env->kvm_vcpu_dirty) { on_vcpu(env, do_kvm_cpu_synchronize_state, env); - env->kvm_vcpu_dirty = 1; } }