From patchwork Mon Nov 16 19:12:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Liguori X-Patchwork-Id: 38538 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B07D0B6F29 for ; Tue, 17 Nov 2009 06:13:33 +1100 (EST) Received: from localhost ([127.0.0.1]:52679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NA710-0005lC-UA for incoming@patchwork.ozlabs.org; Mon, 16 Nov 2009 14:13:30 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NA70T-0005kG-DP for qemu-devel@nongnu.org; Mon, 16 Nov 2009 14:12:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NA70O-0005gf-J9 for qemu-devel@nongnu.org; Mon, 16 Nov 2009 14:12:56 -0500 Received: from [199.232.76.173] (port=54224 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NA70O-0005gY-6u for qemu-devel@nongnu.org; Mon, 16 Nov 2009 14:12:52 -0500 Received: from mail-qy0-f194.google.com ([209.85.221.194]:55801) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NA70N-0006yw-Cl for qemu-devel@nongnu.org; Mon, 16 Nov 2009 14:12:51 -0500 Received: by qyk32 with SMTP id 32so2534190qyk.4 for ; Mon, 16 Nov 2009 11:12:50 -0800 (PST) Received: by 10.224.44.77 with SMTP id z13mr5009939qae.195.1258398770821; Mon, 16 Nov 2009 11:12:50 -0800 (PST) Received: from squirrel.codemonkey.ws ([24.174.33.212]) by mx.google.com with ESMTPS id 22sm150472qyk.14.2009.11.16.11.12.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 16 Nov 2009 11:12:50 -0800 (PST) Message-ID: <4B01A430.1080107@codemonkey.ws> Date: Mon, 16 Nov 2009 13:12:48 -0600 From: Anthony Liguori User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Stefan Weil Subject: Re: [Qemu-devel] Standard vga breakage References: <20091115152858.GH7392@redhat.com> <4B0061B2.2070207@mail.berlios.de> In-Reply-To: <4B0061B2.2070207@mail.berlios.de> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: Blue Swirl , qemu-devel , Gleb Natapov X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Stefan Weil wrote: > malc schrieb: > >> On Sun, 15 Nov 2009, Gleb Natapov wrote: >> >> >>> On Sun, Nov 15, 2009 at 06:22:40PM +0300, malc wrote: >>> >>>> On Sun, 15 Nov 2009, Blue Swirl wrote: >>>> >>>> >>>>> On Sun, Nov 15, 2009 at 3:25 AM, malc wrote: >>>>> >>>>>> debian-503-i386-netinst.iso when booted on a machine with `-vga >>>>>> std' just >>>>>> shows black screen (after bios' setup screen) >>>>>> >>>>> Just some observations: >>>>> - if you press enter, installer starts and Linux is able to fix the >>>>> display >>>>> - the screen is fine with -bios pcbios.bin, so the issue is related >>>>> to SeaBIOS >>>>> >>>> Yes i forgot to mention that -bios works, also worth noting is that >>>> before >>>> the commit that fixed cirrus -bios hack also made it work. >>>> > > > Here is a summary of my analysis of this problem: > > Graphics mode memory (ram 0xe0000000 ...) is not mapped > in QEMU address space (which results in unassigned > memory writes) for standard pci vga (-vga std), so users > don't get vga display output with grub (in graphical mode), > debian installer (in graphical mode) or similar boot software. > 0xe00... is the VBE mapping. The VGABIOS assumes this mapping exists when using VBE. Cirrus doesn't support VBE so it wouldn't be exposed there. Does the following help: Regards, Anthony Liguori diff --git a/hw/vga-pci.c b/hw/vga-pci.c index 479ffb1..e273b8b 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -107,6 +107,12 @@ static int pci_vga_initfn(PCIDevice *dev) PCI_BASE_ADDRESS_MEM_PREFETCH, vga_map); } +#ifdef CONFIG_BOCHS_VBE + /* XXX: use optimized standard vga accesses */ + cpu_register_physical_memory(VBE_DISPI_LFB_PHYSICAL_ADDRESS, + vga_ram_size, s->vga.vram_offset); +#endif + /* ROM BIOS */ rom_add_vga(VGABIOS_FILENAME); return 0;