From patchwork Tue Aug 22 10:41:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 804378 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xc6ZJ1YfBz9t2d for ; Tue, 22 Aug 2017 20:42:16 +1000 (AEST) Received: from localhost ([::1]:60991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dk6dR-00005G-M2 for incoming@patchwork.ozlabs.org; Tue, 22 Aug 2017 06:42:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dk6d2-0008WV-I8 for qemu-devel@nongnu.org; Tue, 22 Aug 2017 06:41:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dk6cz-0005qq-Ef for qemu-devel@nongnu.org; Tue, 22 Aug 2017 06:41:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57112) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dk6cz-0005p9-4d; Tue, 22 Aug 2017 06:41:45 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 04F4A806C0; Tue, 22 Aug 2017 10:41:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 04F4A806C0 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lvivier@redhat.com Received: from [10.36.116.24] (ovpn-116-24.ams2.redhat.com [10.36.116.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE4B581889; Tue, 22 Aug 2017 10:41:40 +0000 (UTC) To: Peter Maydell References: <20170822042416.26758-1-david@gibson.dropbear.id.au> From: Laurent Vivier Message-ID: <329bff28-5804-2d39-7bd8-9336eaaf9d26@redhat.com> Date: Tue, 22 Aug 2017 12:41:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 22 Aug 2017 10:41:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , QEMU Developers , Cornelia Huck , Michael Roth , Alexander Graf , Greg Kurz , "qemu-ppc@nongnu.org" , Daniel Henrique Barboza , David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" On 22/08/2017 11:53, Peter Maydell wrote: > On 22 August 2017 at 10:43, Laurent Vivier wrote: >> On 22/08/2017 11:34, Peter Maydell wrote: >>> On 22 August 2017 at 05:24, David Gibson wrote: >>>> The following changes since commit 1f296733876434118fd766cfef5eb6f29ecab6a8: >>>> >>>> Update version for v2.10.0-rc3 release (2017-08-15 18:53:31 +0100) >>>> >>>> are available in the git repository at: >>>> >>>> git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170822 >>>> >>>> for you to fetch changes up to d3234e2851f1630c695c681beac1e87ac0881260: >>>> >>>> hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device (2017-08-22 11:11:30 +1000) >>>> >>>> ---------------------------------------------------------------- >>>> ppc patch queue 2017-08-22 >>>> >>>> Last minute ppc related fixes for qemu-2.10. I'm not sure if these >>>> are critical enough to prompt another rc, but I'm submitting them for >>>> consideration. >>>> >>>> First, is Cornelia's fix for 480bc11e6 which meant "make check" would >>>> always fail on a ppc host. Tracking that down delayed submission of >>>> the rest of these patches, sorry. >>>> >>>> The rest are all fairly important bugfixes for qemu crashes or guest >>>> behaviour regression on ppc. Patches 2-4 specifically are fixes for >>>> regressions from qemu-2.9, caused by the compatibility mode and >>>> hotplug handling cleanups for the pseries machine type. >>>> >>>> ---------------------------------------------------------------- >>> >>> I get a make check failure on ppc64 Linux: >>> >>> TEST: tests/postcopy-test... (pid=12468) >>> /ppc64/postcopy: >>> Broken pipe >>> qemu-system-ppc64: RP: Received invalid message 0x0000 length 0x0000 >>> FAIL >>> GTester: last random seed: R02Se5468e06f561627824306d95b0566d2b >>> (pid=13011) >>> FAIL: tests/postcopy-test The problem is in: bool kvmppc_pvr_workaround_required(PowerPCCPU *cpu) { CPUState *cs = CPU(cpu); if (cap_ppc_pvr_compat) { return false; } return !kvmppc_is_pr(cs->kvm_state); } It guesses !kvm pr means kvm_hv. That is not true, it can be TCG. This fixes the problem for me: [CC' Daniel] Thanks, Laurent --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2817,5 +2817,5 @@ bool kvmppc_pvr_workaround_required(PowerPCCPU *cpu) return false; } - return !kvmppc_is_pr(cs->kvm_state); + return kvm_enabled() && !kvmppc_is_pr(cs->kvm_state); }