From patchwork Fri Oct 13 07:56:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manos Pitsidianakis X-Patchwork-Id: 1847978 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=OB9V/7IR; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S6K184YbTz1yqZ for ; Fri, 13 Oct 2023 19:09:48 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrD4f-0001nl-8b; Fri, 13 Oct 2023 03:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrD4W-0000yu-Oq for qemu-devel@nongnu.org; Fri, 13 Oct 2023 03:59:01 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrD4R-0006vc-Nw for qemu-devel@nongnu.org; Fri, 13 Oct 2023 03:58:57 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40572aeb673so19510075e9.0 for ; Fri, 13 Oct 2023 00:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697183929; x=1697788729; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aZ1hqe+Fu2cE5EdVcsb+6IpRINRQWQg+aUhoqPZ6lw8=; b=OB9V/7IR4U/DOctZttQ58E60e7ZZ5u+fOHA2+EvckqYKEOMZSGU7HsKs7PGMmY7Q2+ e4xsOXHRsh9K+nrGxYye8ySx6qvVnZu1havpm7qXszxFU69QWpEmdLXsSB3qGAAlz3yE 5/Xb8zkMfpHn5Yt0rH8ei8xUIY2syO3eG9Y1KOGr7sCLyxFMX3x4WSgBmxrNsN2hwYJV EawadeeSKE58gEr1uQe1jHLgU3A2dROhRjWtV6gW0EuUTrE4pbmLYuEJJEPq7AitJ5/a OoMt6IjNls1Ghg3S+h4EaI8t8AM4kWu4UljERs7m8grqUZrMaQc+3THeKZ5BpOwCMEHu /m5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697183929; x=1697788729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aZ1hqe+Fu2cE5EdVcsb+6IpRINRQWQg+aUhoqPZ6lw8=; b=ZS//tQmGy5LQTqweUTEUhBxJd9mNR1rbNVzdAIuf1t57xUiEUExmWZVBxq2IY/WvHv DeHG5CDgvsgggpW2/EL2wNnAscbdRj60gRgRJaGpGZ9PfUfrFFSarpOrPk/RNGk5w2ep rpsphVf3LW1XFeAj4/aczd9OLGplpPKFImwV8shsKr069cdJ+V6+zkBuKzNZIB2wL+dr YHxzNJSq/Xy7Keip+djKnuE0guEiDi5xNgIa4iRgbta8zmqSQ5qj1XitXTtdu34krva0 324Pd5DHvfD+bCAAgXAaSMBH56dbsa3AHhjMVjCPIc0PiRUNIcz1mOHUwwgPxHOyPcwy DKkw== X-Gm-Message-State: AOJu0YzGprFS33oecIdgwKk/C8zLa/EEpluFHtaCWVkSW5Y5woaaVOOB FOPDMAbi6GsESCYKQ0HVMZi1j5peyt+L5bti+zs= X-Google-Smtp-Source: AGHT+IGqC33mqoNQtKuBzGSAQxVQYg/kbNTH7S+/A9htsE7Tt8lxWJCru4Rn8EIa2Dpq2f9o8u7EoA== X-Received: by 2002:a05:600c:510a:b0:406:c6de:2bea with SMTP id o10-20020a05600c510a00b00406c6de2beamr18831930wms.17.1697183929679; Fri, 13 Oct 2023 00:58:49 -0700 (PDT) Received: from localhost.localdomain (adsl-26.37.6.0.tellas.gr. [37.6.0.26]) by smtp.gmail.com with ESMTPSA id a10-20020a05600c224a00b003fe23b10fdfsm1798183wmm.36.2023.10.13.00.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 00:58:49 -0700 (PDT) From: Emmanouil Pitsidianakis To: qemu-devel@nongnu.org Cc: Emmanouil Pitsidianakis , "Edgar E. Iglesias" Subject: [RFC PATCH v2 29/78] target/cris: add fallthrough pseudo-keyword Date: Fri, 13 Oct 2023 10:56:56 +0300 Message-Id: <295dcd972e29e2d4adb367e52199d7e412906405.1697183699.git.manos.pitsidianakis@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- target/cris/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index b3974ba0bb..bdd128db23 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -3061,94 +3061,94 @@ static void cris_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) static void cris_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu) { DisasContext *dc = container_of(dcbase, DisasContext, base); DisasJumpType is_jmp = dc->base.is_jmp; target_ulong npc = dc->pc; if (is_jmp == DISAS_NORETURN) { /* If we have a broken branch+delayslot sequence, it's too late. */ assert(dc->delayed_branch != 1); return; } if (dc->clear_locked_irq) { t_gen_movi_env_TN(locked_irq, 0); } /* Broken branch+delayslot sequence. */ if (dc->delayed_branch == 1) { /* Set env->dslot to the size of the branch insn. */ t_gen_movi_env_TN(dslot, dc->pc - dc->ppc); cris_store_direct_jmp(dc); } cris_evaluate_flags(dc); /* Evaluate delayed branch destination and fold to another is_jmp case. */ if (is_jmp == DISAS_DBRANCH) { if (dc->base.tb->flags & 7) { t_gen_movi_env_TN(dslot, 0); } switch (dc->jmp) { case JMP_DIRECT: npc = dc->jmp_pc; is_jmp = dc->cpustate_changed ? DISAS_UPDATE_NEXT : DISAS_TOO_MANY; break; case JMP_DIRECT_CC: /* * Use a conditional branch if either taken or not-taken path * can use goto_tb. If neither can, then treat it as indirect. */ if (likely(!dc->cpustate_changed) && (use_goto_tb(dc, dc->jmp_pc) || use_goto_tb(dc, npc))) { TCGLabel *not_taken = gen_new_label(); tcg_gen_brcondi_tl(TCG_COND_EQ, env_btaken, 0, not_taken); gen_goto_tb(dc, 1, dc->jmp_pc); gen_set_label(not_taken); /* not-taken case handled below. */ is_jmp = DISAS_TOO_MANY; break; } tcg_gen_movi_tl(env_btarget, dc->jmp_pc); - /* fall through */ + fallthrough; case JMP_INDIRECT: tcg_gen_movcond_tl(TCG_COND_NE, env_pc, env_btaken, tcg_constant_tl(0), env_btarget, tcg_constant_tl(npc)); is_jmp = dc->cpustate_changed ? DISAS_UPDATE : DISAS_JUMP; /* * We have now consumed btaken and btarget. Hint to the * tcg compiler that the writeback to env may be dropped. */ tcg_gen_discard_tl(env_btaken); tcg_gen_discard_tl(env_btarget); break; default: g_assert_not_reached(); } } switch (is_jmp) { case DISAS_TOO_MANY: gen_goto_tb(dc, 0, npc); break; case DISAS_UPDATE_NEXT: tcg_gen_movi_tl(env_pc, npc); - /* fall through */ + fallthrough; case DISAS_JUMP: tcg_gen_lookup_and_goto_ptr(); break; case DISAS_UPDATE: /* Indicate that interrupts must be re-evaluated before the next TB. */ tcg_gen_exit_tb(NULL, 0); break; default: g_assert_not_reached(); } }