diff mbox

glusterfs: do not log to stdout if daemonized

Message ID 24E144B8C0207547AD09C467A8259F755D0ACF37@lisa.maurer-it.com
State New
Headers show

Commit Message

Dietmar Maurer Aug. 22, 2014, 11:57 a.m. UTC 
Else stdout is not closed correctly.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>

Comments

Stefan Hajnoczi Aug. 27, 2014, 3:11 p.m. UTC | #1 
On Fri, Aug 22, 2014 at 11:57:18AM +0000, Dietmar Maurer wrote:
> Else stdout is not closed correctly.

glfs_set_logging(glfs, "-", 4) uses stderr, not stdout.

The intention is to log errors along with QEMU's own error messages that
go to stderr.

Can you explain the details of the problem?
diff mbox

Patch

Index: new/block/gluster.c
===================================================================
--- new.orig/block/gluster.c	2014-08-22 13:21:39.000000000 +0200
+++ new/block/gluster.c	2014-08-22 13:25:18.000000000 +0200
@@ -196,9 +196,11 @@ 
      * TODO: Use GF_LOG_ERROR instead of hard code value of 4 here when
      * GlusterFS makes GF_LOG_* macros available to libgfapi users.
      */
-    ret = glfs_set_logging(glfs, "-", 4);
-    if (ret < 0) {
-        goto out;
+    if (!is_daemonized()) {
+        ret = glfs_set_logging(glfs, "-", 4);
+        if (ret < 0) {
+            goto out;
+        }
     }
 
     ret = glfs_init(glfs);