| Message ID | 20240617185804.25075-12-itachis@FreeBSD.org |
|---|---|
| State | New |
| Headers | show |
| Series | ARM AArch64 Support for BSD | expand |
On 6/17/24 11:57, Ajeet Singh wrote: > From: Stacey Son <sson@FreeBSD.org> > > Defined address spaces for FreeBSD/arm64 and added function for > getting stack pointer from CPU and setting a return value. > > Signed-off-by: Stacey Son <sson@FreeBSD.org> > Signed-off-by: Warner Losh <imp@bsdimp.com> > Signed-off-by: Ajeet Singh <itachis@FreeBSD.org> > Co-authored-by: Sean Bruno <sbruno@freebsd.org> > Co-authored-by: Warner Losh <imp@bsdimp.com> > --- > bsd-user/aarch64/target_arch_vmparam.h | 68 ++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 bsd-user/aarch64/target_arch_vmparam.h Acked-by: Richard Henderson <richard.henderson@linaro.org> > + /* KERNBASE - 512 MB */ > +#define TARGET_VM_MAXUSER_ADDRESS (0x00007fffff000000ULL - (512 * MiB)) > +#define TARGET_USRSTACK TARGET_VM_MAXUSER_ADDRESS I will note that this may conflict with -R reserved_size, and is an existing issue with the x86_64 port as well. r~
On Tue, Jun 18, 2024 at 4:16 PM Richard Henderson < richard.henderson@linaro.org> wrote: > On 6/17/24 11:57, Ajeet Singh wrote: > > From: Stacey Son <sson@FreeBSD.org> > > > > Defined address spaces for FreeBSD/arm64 and added function for > > getting stack pointer from CPU and setting a return value. > > > > Signed-off-by: Stacey Son <sson@FreeBSD.org> > > Signed-off-by: Warner Losh <imp@bsdimp.com> > > Signed-off-by: Ajeet Singh <itachis@FreeBSD.org> > > Co-authored-by: Sean Bruno <sbruno@freebsd.org> > > Co-authored-by: Warner Losh <imp@bsdimp.com> > > --- > > bsd-user/aarch64/target_arch_vmparam.h | 68 ++++++++++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > create mode 100644 bsd-user/aarch64/target_arch_vmparam.h > > Acked-by: Richard Henderson <richard.henderson@linaro.org> > > > + /* KERNBASE - 512 MB */ > > +#define TARGET_VM_MAXUSER_ADDRESS (0x00007fffff000000ULL - (512 * > MiB)) > > +#define TARGET_USRSTACK TARGET_VM_MAXUSER_ADDRESS > > I will note that this may conflict with -R reserved_size, > and is an existing issue with the x86_64 port as well. > There are indeed existing issues with address space management. We're working through them right now in the blitz branch. We have finally found where the atomic issues were coming from and it is <blush> not setting the flag saying we want atomic ops when creating the CPU structures (that's a quick summary, I'll post more on this later when we review it). So I'd suggest, for the moment, allowing this in and fixing it when we get those details ironed out. Does that sound OK? Warner
diff --git a/bsd-user/aarch64/target_arch_vmparam.h b/bsd-user/aarch64/target_arch_vmparam.h new file mode 100644 index 0000000000..dc66e1289b --- /dev/null +++ b/bsd-user/aarch64/target_arch_vmparam.h @@ -0,0 +1,68 @@ +/* + * ARM AArch64 VM parameters definitions for bsd-user. + * + * Copyright (c) 2015 Stacey D. Son <sson at FreeBSD> + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see <http://www.gnu.org/licenses/>. + */ + +#ifndef TARGET_ARCH_VMPARAM_H +#define TARGET_ARCH_VMPARAM_H + +#include "cpu.h" + +/** + * FreeBSD/arm64 Address space layout. + * + * ARMv8 implements up to a 48 bit virtual address space. The address space is + * split into 2 regions at each end of the 64 bit address space, with an + * out of range "hole" in the middle. + * + * We limit the size of the two spaces to 39 bits each. + * + * Upper region: 0xffffffffffffffff + * 0xffffff8000000000 + * + * Hole: 0xffffff7fffffffff + * 0x0000008000000000 + * + * Lower region: 0x0000007fffffffff + * 0x0000000000000000 + * + * The upper region for the kernel, and the lower region for userland. + */ + + +/* compare to sys/arm64/include/vmparam.h */ +#define TARGET_MAXTSIZ (1 * GiB) /* max text size */ +#define TARGET_DFLDSIZ (128 * MiB) /* initial data size limit */ +#define TARGET_MAXDSIZ (1 * GiB) /* max data size */ +#define TARGET_DFLSSIZ (128 * MiB) /* initial stack size limit */ +#define TARGET_MAXSSIZ (1 * GiB) /* max stack size */ +#define TARGET_SGROWSIZ (128 * KiB) /* amount to grow stack */ + + /* KERNBASE - 512 MB */ +#define TARGET_VM_MAXUSER_ADDRESS (0x00007fffff000000ULL - (512 * MiB)) +#define TARGET_USRSTACK TARGET_VM_MAXUSER_ADDRESS + +static inline abi_ulong get_sp_from_cpustate(CPUARMState *state) +{ + return state->xregs[31]; /* sp */ +} + +static inline void set_second_rval(CPUARMState *state, abi_ulong retval2) +{ + state->xregs[1] = retval2; /* XXX not really used on 64-bit arch */ +} +#endif /* TARGET_ARCH_VMPARAM_H */