diff mbox series

[3/4] hw/s390x: Deprecate the HMP 'dump_skeys' command

Message ID 20240530074544.25444-4-philmd@linaro.org
State New
Headers show
Series hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate | expand

Commit Message

Philippe Mathieu-Daudé May 30, 2024, 7:45 a.m. UTC 
Prefer 'dump_s390_skeys' which is target agnostic.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/s390x/s390-skeys.c | 2 ++
 hmp-commands.hx       | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c
index e7dab52a6e..12ec8a808e 100644
--- a/hw/s390x/s390-skeys.c
+++ b/hw/s390x/s390-skeys.c
@@ -120,6 +120,8 @@  void hmp_dump_s390_skeys(Monitor *mon, const QDict *qdict)
 
 void hmp_dump_skeys(Monitor *mon, const QDict *qdict)
 {
+    monitor_printf(mon, "This command is deprecated"
+                        " (replaced by 'dump-s390-skeys')\n");
     hmp_dump_s390_skeys(mon, qdict);
 }
 
diff --git a/hmp-commands.hx b/hmp-commands.hx
index c12e2c2bd9..04ae897134 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1138,14 +1138,14 @@  ERST
         .name       = "dump-skeys",
         .args_type  = "filename:F",
         .params     = "",
-        .help       = "Save guest storage keys into file 'filename'.\n",
+        .help       = "deprecated synonym for dump-s390-skeys.",
         .cmd        = hmp_dump_skeys,
     },
 #endif
 
 SRST
 ``dump-skeys`` *filename*
-  Save guest storage keys to a file.
+  This is a deprecated synonym for the dump-s390-skeys command.
 ERST
 
 #if defined(TARGET_S390X)