| Message ID | 20240514153130.394307-10-clg@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | vfio: Improve error reporting (part 2 | expand |
On 5/14/24 17:31, Cédric Le Goater wrote: > vfio_save_complete_precopy() currently returns before doing the trace > event. Change that. > > Reviewed-by: Avihai Horon <avihaih@nvidia.com> > Signed-off-by: Cédric Le Goater <clg@redhat.com> > --- > hw/vfio/migration.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c > index d089fa9b937e725307c1a56755495d5b8fae2065..b06d887df53155e676bf13fa03adaf0627841994 100644 > --- a/hw/vfio/migration.c > +++ b/hw/vfio/migration.c > @@ -585,9 +585,6 @@ static int vfio_save_complete_precopy(QEMUFile *f, void *opaque) > > qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE); > ret = qemu_file_get_error(f); > - if (ret) { > - return ret; > - } > > trace_vfio_save_complete_precopy(vbasedev->name, ret); > Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index d089fa9b937e725307c1a56755495d5b8fae2065..b06d887df53155e676bf13fa03adaf0627841994 100644 --- a/hw/vfio/migration.c +++ b/hw/vfio/migration.c @@ -585,9 +585,6 @@ static int vfio_save_complete_precopy(QEMUFile *f, void *opaque) qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE); ret = qemu_file_get_error(f); - if (ret) { - return ret; - } trace_vfio_save_complete_precopy(vbasedev->name, ret);