From patchwork Thu May 2 09:56:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1930575 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BWEW6nVM; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VVTrQ1Lrzz1ydT for ; Thu, 2 May 2024 19:57:42 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2TBb-0000gu-Vq; Thu, 02 May 2024 05:57:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2TBZ-0000eL-Rv for qemu-devel@nongnu.org; Thu, 02 May 2024 05:57:05 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2TBX-00019W-JQ for qemu-devel@nongnu.org; Thu, 02 May 2024 05:57:04 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-41b5e74fa83so51910315e9.0 for ; Thu, 02 May 2024 02:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714643822; x=1715248622; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OWnrA6E91+7xAaPI8kCn9o7Y7ybTIOe7+SUe3y8pkFw=; b=BWEW6nVMH90wQe/RV5ddg5LIKPiqhQF07BYhxegi/dG2+klv6/U+uHbuPGY2VOmuBI 4hlvzxmaR1Y9I13RvOzEG3aFsosdulGLGFmAvFJ/AAMNlVvGgisEgCNtCAbZ6XrkqMDy xk5sQNGOt5IPuwSEcYIIisnioKWVaSlLt+pY1DFtR83URpENFh9LY1GU215XdDYLXA+B a5XlE69qiqtJqOwSxnitYg4C4+CFbHM/GfP+BiEaulGhyna2gavK8gJc/zqAyr7nL4j5 hDVK3ocuNtGX0JuH2MbmUczns1M2vf5achAHoJoD4jAO1oJj5N5eE8bsxgU8i3Gh5XO5 AjZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714643822; x=1715248622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OWnrA6E91+7xAaPI8kCn9o7Y7ybTIOe7+SUe3y8pkFw=; b=EYinyKU/+cETJaJFhECQygW1n8kp/hWgp7iMPvVKeEuO2OVvOv9JYqZ/29cDtTcq+t Jmh/JUZTfAPgwCOHdjeDB2pwnaoUDUoG/DTiZLJGbkJ/zO5ZgSr9IhPCO4hYYxKFuOLO 6L1v4QRGIaYqsmMsKAyR5/ENudVgaipOZUDGnkdeYjosXjxBGwnlu7Ks4+dGnWc4yB6Y JB6hc8WtjOiNkYERhxSVA7nlOCvOINCNMnv13RbF9a4hCcjnCDey1jE7sonyuXqLGhZc 6HewYb9d33dgvP+tQ2MH/ZmGMU8k2WTnFNfKzgmfjR6cehWE3haNDTOuVQEmL6/g/2VW f0nA== X-Gm-Message-State: AOJu0Yyn/VkH371dK8v4xkEGf8gvrqeF4mYwvkvNGoAO2OW1GcdcN6I+ 1NASdapyB80u2zdXlf6CaNrmJkANAHeqS7t4VHmk8wliq0FN+HXkeBfKLM0mBdZ7//2lznYp6Fc / X-Google-Smtp-Source: AGHT+IEmk6ue13PnbZ9dFBQt7wOV7TTFIcyk8Mxq17s74JZ1rPy4K/FqCytBY3jrHqPCMrTEnwyHVA== X-Received: by 2002:a05:600c:444d:b0:418:ed23:a9f0 with SMTP id v13-20020a05600c444d00b00418ed23a9f0mr3554308wmn.18.1714643821957; Thu, 02 May 2024 02:57:01 -0700 (PDT) Received: from m1x-phil.lan ([176.187.215.106]) by smtp.gmail.com with ESMTPSA id n21-20020a05600c3b9500b0041a9fc2a6b5sm5111895wms.20.2024.05.02.02.57.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 02 May 2024 02:57:01 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?M?= =?utf-8?q?arc-Andr=C3=A9_Lureau?= , Thomas Huth , Paolo Bonzini , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/3] crypto: Allow building with GnuTLS but without Libtasn1 Date: Thu, 2 May 2024 11:56:42 +0200 Message-ID: <20240502095642.93368-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240502095642.93368-1-philmd@linaro.org> References: <20240502095642.93368-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We only use Libtasn1 in unit tests. As noted in commit d47b83b118 ("tests: add migration tests of TLS with x509 credentials"), having GnuTLS without Libtasn1 is a valid configuration, so do not require Libtasn1, to avoid: Dependency gnutls found: YES 3.7.1 (cached) Run-time dependency libtasn1 found: NO (tried pkgconfig) ../meson.build:1914:10: ERROR: Dependency "libtasn1" not found, tried pkgconfig Fixes: ba7ed407e6 ("configure, meson: convert libtasn1 detection to meson") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 5db2dbc12e..837a2bdb56 100644 --- a/meson.build +++ b/meson.build @@ -1912,6 +1912,7 @@ endif tasn1 = not_found if gnutls.found() tasn1 = dependency('libtasn1', + required: false, method: 'pkg-config') endif keyutils = not_found