diff mbox series

[v2,01/18] meson: do not link pixman automatically into all targets

Message ID 20240408155330.522792-2-pbonzini@redhat.com
State New
Headers show
Series buildsys: Start shrinking qemu-user build process | expand

Commit Message

Paolo Bonzini April 8, 2024, 3:53 p.m. UTC
The dependency on pixman is listed manually in all sourcesets that need it.
There is no need to bring into libqemuutil, since there is nothing in
util/ that needs pixman either.

Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson April 8, 2024, 4:41 p.m. UTC | #1
On 4/8/24 05:53, Paolo Bonzini wrote:
> The dependency on pixman is listed manually in all sourcesets that need it.
> There is no need to bring into libqemuutil, since there is nothing in
> util/ that needs pixman either.
> 
> Reported-by: Michael Tokarev<mjt@tls.msk.ru>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index c9c3217ba4b..09668e3c5f5 100644
--- a/meson.build
+++ b/meson.build
@@ -3477,7 +3477,7 @@  util_ss = util_ss.apply({})
 libqemuutil = static_library('qemuutil',
                              build_by_default: false,
                              sources: util_ss.sources() + stub_ss.sources() + genh,
-                             dependencies: [util_ss.dependencies(), libm, threads, glib, socket, malloc, pixman])
+                             dependencies: [util_ss.dependencies(), libm, threads, glib, socket, malloc])
 qemuutil = declare_dependency(link_with: libqemuutil,
                               sources: genh + version_res,
                               dependencies: [event_loop_base])