From patchwork Sun Mar 17 10:39:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnaud Minier X-Patchwork-Id: 1912883 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=telecom-paris.fr header.i=@telecom-paris.fr header.a=rsa-sha256 header.s=A35C7578-1106-11E5-A17F-C303FDDA8F2E header.b=ryd0oXLo; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TyF0f32Q5z1yWv for ; Sun, 17 Mar 2024 21:41:54 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlnxR-00036L-1b; Sun, 17 Mar 2024 06:41:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlnx7-0002j0-SY; Sun, 17 Mar 2024 06:41:19 -0400 Received: from zproxy4.enst.fr ([137.194.2.223]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlnx3-0001PG-6W; Sun, 17 Mar 2024 06:41:16 -0400 Received: from localhost (localhost [IPv6:::1]) by zproxy4.enst.fr (Postfix) with ESMTP id 958B7205A4; Sun, 17 Mar 2024 11:41:10 +0100 (CET) Received: from zproxy4.enst.fr ([IPv6:::1]) by localhost (zproxy4.enst.fr [IPv6:::1]) (amavis, port 10032) with ESMTP id ZyZmxp1mnQN3; Sun, 17 Mar 2024 11:41:09 +0100 (CET) Received: from localhost (localhost [IPv6:::1]) by zproxy4.enst.fr (Postfix) with ESMTP id C858B2061D; Sun, 17 Mar 2024 11:41:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.10.3 zproxy4.enst.fr C858B2061D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telecom-paris.fr; s=A35C7578-1106-11E5-A17F-C303FDDA8F2E; t=1710672068; bh=5GDvnMu2ewIpK7fNk9UMMPgm5GCnbCl9hPbVOlmLn+A=; h=From:To:Date:Message-Id:MIME-Version; b=ryd0oXLo5rPZ4Uxto/c1tWLq/Jh8kJZZ6J+J0uvRR2kNH8n4/c0znnSSQJONtJhm9 0T40wNskuI/yqvuy/+t0rKd3jbpEjKQP8vBq7K/LEMn7essjUpeksh70CdErZvvRuq KXd58KwAQY53FF6LfdqaYozhDb33bRvOicTJPytc= X-Virus-Scanned: amavis at enst.fr Received: from zproxy4.enst.fr ([IPv6:::1]) by localhost (zproxy4.enst.fr [IPv6:::1]) (amavis, port 10026) with ESMTP id LYl-nYQxjC9L; Sun, 17 Mar 2024 11:41:08 +0100 (CET) Received: from AM-Inspiron-3585.. (cust-west-par-46-193-4-103.cust.wifirst.net [46.193.4.103]) by zproxy4.enst.fr (Postfix) with ESMTPSA id CB612205F4; Sun, 17 Mar 2024 11:41:07 +0100 (CET) From: Arnaud Minier To: qemu-devel@nongnu.org Cc: Samuel Tardieu , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Alistair Francis , Paolo Bonzini , =?utf-8?q?In=C3=A8s_Varhol?= , Peter Maydell , qemu-arm@nongnu.org, Laurent Vivier , Thomas Huth , Arnaud Minier Subject: [PATCH 3/7] hw/char/stm32l4x5_usart: Add USART, UART, LPUART types Date: Sun, 17 Mar 2024 11:39:14 +0100 Message-Id: <20240317103918.44375-4-arnaud.minier@telecom-paris.fr> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240317103918.44375-1-arnaud.minier@telecom-paris.fr> References: <20240317103918.44375-1-arnaud.minier@telecom-paris.fr> MIME-Version: 1.0 Received-SPF: pass client-ip=137.194.2.223; envelope-from=arnaud.minier@telecom-paris.fr; helo=zproxy4.enst.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Create different types for the USART, UART and LPUART of the STM32L4x5 to deduplicate code and enable the implementation of different behaviors depending on the type. Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/char/stm32l4x5_usart.c | 113 +++++++++++++++++++----------- include/hw/char/stm32l4x5_usart.h | 21 +++++- 2 files changed, 92 insertions(+), 42 deletions(-) diff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c index b56fee5b3a..f58bd56875 100644 --- a/hw/char/stm32l4x5_usart.c +++ b/hw/char/stm32l4x5_usart.c @@ -154,9 +154,9 @@ REG32(RDR, 0x24) REG32(TDR, 0x28) FIELD(TDR, TDR, 0, 8) -static void stm32l4x5_usart_reset_hold(Object *obj) +static void stm32l4x5_usart_base_reset_hold(Object *obj) { - STM32L4X5UsartState *s = STM32L4X5_USART(obj); + Stm32l4x5UsartBaseState *s = STM32L4X5_USART_BASE(obj); s->cr1 = 0x00000000; s->cr2 = 0x00000000; @@ -170,10 +170,10 @@ static void stm32l4x5_usart_reset_hold(Object *obj) s->tdr = 0x00000000; } -static uint64_t stm32l4x5_usart_read(void *opaque, hwaddr addr, - unsigned int size) +static uint64_t stm32l4x5_usart_base_read(void *opaque, hwaddr addr, + unsigned int size) { - STM32L4X5UsartState *s = opaque; + Stm32l4x5UsartBaseState *s = opaque; uint64_t retvalue = 0; switch (addr) { @@ -225,10 +225,10 @@ static uint64_t stm32l4x5_usart_read(void *opaque, hwaddr addr, return retvalue; } -static void stm32l4x5_usart_write(void *opaque, hwaddr addr, +static void stm32l4x5_usart_base_write(void *opaque, hwaddr addr, uint64_t val64, unsigned int size) { - STM32L4X5UsartState *s = opaque; + Stm32l4x5UsartBaseState *s = opaque; const uint32_t value = val64; uint8_t ch; @@ -276,9 +276,9 @@ static void stm32l4x5_usart_write(void *opaque, hwaddr addr, } } -static const MemoryRegionOps stm32l4x5_usart_ops = { - .read = stm32l4x5_usart_read, - .write = stm32l4x5_usart_write, +static const MemoryRegionOps stm32l4x5_usart_base_ops = { + .read = stm32l4x5_usart_base_read, + .write = stm32l4x5_usart_base_write, .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .max_access_size = 4, @@ -292,72 +292,105 @@ static const MemoryRegionOps stm32l4x5_usart_ops = { }, }; -static Property stm32l4x5_usart_properties[] = { - DEFINE_PROP_CHR("chardev", STM32L4X5UsartState, chr), +static Property stm32l4x5_usart_base_properties[] = { + DEFINE_PROP_CHR("chardev", Stm32l4x5UsartBaseState, chr), DEFINE_PROP_END_OF_LIST(), }; -static void stm32l4x5_usart_init(Object *obj) +static void stm32l4x5_usart_base_init(Object *obj) { - STM32L4X5UsartState *s = STM32L4X5_USART(obj); + Stm32l4x5UsartBaseState *s = STM32L4X5_USART_BASE(obj); sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq); - memory_region_init_io(&s->mmio, obj, &stm32l4x5_usart_ops, s, - TYPE_STM32L4X5_USART, 0x400); + memory_region_init_io(&s->mmio, obj, &stm32l4x5_usart_base_ops, s, + TYPE_STM32L4X5_USART_BASE, 0x400); sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); s->clk = qdev_init_clock_in(DEVICE(s), "clk", NULL, s, 0); } -static const VMStateDescription vmstate_stm32l4x5_usart = { - .name = TYPE_STM32L4X5_USART, +static const VMStateDescription vmstate_stm32l4x5_usart_base = { + .name = TYPE_STM32L4X5_USART_BASE, .version_id = 1, .minimum_version_id = 1, .fields = (VMStateField[]) { - VMSTATE_UINT32(cr1, STM32L4X5UsartState), - VMSTATE_UINT32(cr2, STM32L4X5UsartState), - VMSTATE_UINT32(cr3, STM32L4X5UsartState), - VMSTATE_UINT32(brr, STM32L4X5UsartState), - VMSTATE_UINT32(gtpr, STM32L4X5UsartState), - VMSTATE_UINT32(rtor, STM32L4X5UsartState), - VMSTATE_UINT32(isr, STM32L4X5UsartState), - VMSTATE_UINT32(rdr, STM32L4X5UsartState), - VMSTATE_UINT32(tdr, STM32L4X5UsartState), - VMSTATE_CLOCK(clk, STM32L4X5UsartState), + VMSTATE_UINT32(cr1, Stm32l4x5UsartBaseState), + VMSTATE_UINT32(cr2, Stm32l4x5UsartBaseState), + VMSTATE_UINT32(cr3, Stm32l4x5UsartBaseState), + VMSTATE_UINT32(brr, Stm32l4x5UsartBaseState), + VMSTATE_UINT32(gtpr, Stm32l4x5UsartBaseState), + VMSTATE_UINT32(rtor, Stm32l4x5UsartBaseState), + VMSTATE_UINT32(isr, Stm32l4x5UsartBaseState), + VMSTATE_UINT32(rdr, Stm32l4x5UsartBaseState), + VMSTATE_UINT32(tdr, Stm32l4x5UsartBaseState), + VMSTATE_CLOCK(clk, Stm32l4x5UsartBaseState), VMSTATE_END_OF_LIST() } }; -static void stm32l4x5_usart_realize(DeviceState *dev, Error **errp) +static void stm32l4x5_usart_base_realize(DeviceState *dev, Error **errp) { ERRP_GUARD(); - STM32L4X5UsartState *s = STM32L4X5_USART(dev); + Stm32l4x5UsartBaseState *s = STM32L4X5_USART_BASE(dev); if (!clock_has_source(s->clk)) { error_setg(errp, "USART clock must be wired up by SoC code"); return; } } -static void stm32l4x5_usart_class_init(ObjectClass *klass, void *data) +static void stm32l4x5_usart_base_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); ResettableClass *rc = RESETTABLE_CLASS(klass); - rc->phases.hold = stm32l4x5_usart_reset_hold; - device_class_set_props(dc, stm32l4x5_usart_properties); - dc->realize = stm32l4x5_usart_realize; - dc->vmsd = &vmstate_stm32l4x5_usart; + rc->phases.hold = stm32l4x5_usart_base_reset_hold; + device_class_set_props(dc, stm32l4x5_usart_base_properties); + dc->realize = stm32l4x5_usart_base_realize; + dc->vmsd = &vmstate_stm32l4x5_usart_base; +} + +static void stm32l4x5_usart_class_init(ObjectClass *oc, void *data) +{ + Stm32l4x5UsartBaseClass *subc = STM32L4X5_USART_BASE_CLASS(oc); + + subc->type = STM32L4x5_USART; +} + +static void stm32l4x5_uart_class_init(ObjectClass *oc, void *data) +{ + Stm32l4x5UsartBaseClass *subc = STM32L4X5_USART_BASE_CLASS(oc); + + subc->type = STM32L4x5_UART; +} + +static void stm32l4x5_lpuart_class_init(ObjectClass *oc, void *data) +{ + Stm32l4x5UsartBaseClass *subc = STM32L4X5_USART_BASE_CLASS(oc); + + subc->type = STM32L4x5_LPUART; } static const TypeInfo stm32l4x5_usart_types[] = { { - .name = TYPE_STM32L4X5_USART, - .parent = TYPE_SYS_BUS_DEVICE, - .instance_size = sizeof(STM32L4X5UsartState), - .instance_init = stm32l4x5_usart_init, - .class_init = stm32l4x5_usart_class_init, + .name = TYPE_STM32L4X5_USART_BASE, + .parent = TYPE_SYS_BUS_DEVICE, + .instance_size = sizeof(Stm32l4x5UsartBaseState), + .instance_init = stm32l4x5_usart_base_init, + .class_init = stm32l4x5_usart_base_class_init, + }, { + .name = TYPE_STM32L4X5_USART, + .parent = TYPE_STM32L4X5_USART_BASE, + .class_init = stm32l4x5_usart_class_init, + }, { + .name = TYPE_STM32L4X5_UART, + .parent = TYPE_STM32L4X5_USART_BASE, + .class_init = stm32l4x5_uart_class_init, + }, { + .name = TYPE_STM32L4X5_LPUART, + .parent = TYPE_STM32L4X5_USART_BASE, + .class_init = stm32l4x5_lpuart_class_init, } }; diff --git a/include/hw/char/stm32l4x5_usart.h b/include/hw/char/stm32l4x5_usart.h index 8ec1b7afed..8d38a85a6e 100644 --- a/include/hw/char/stm32l4x5_usart.h +++ b/include/hw/char/stm32l4x5_usart.h @@ -22,10 +22,20 @@ #include "chardev/char-fe.h" #include "qom/object.h" +#define TYPE_STM32L4X5_USART_BASE "stm32l4x5-usart-base" #define TYPE_STM32L4X5_USART "stm32l4x5-usart" -OBJECT_DECLARE_SIMPLE_TYPE(STM32L4X5UsartState, STM32L4X5_USART) +#define TYPE_STM32L4X5_UART "stm32l4x5-uart" +#define TYPE_STM32L4X5_LPUART "stm32l4x5-lpuart" +OBJECT_DECLARE_TYPE(Stm32l4x5UsartBaseState, Stm32l4x5UsartBaseClass, + STM32L4X5_USART_BASE) -struct STM32L4X5UsartState { +typedef enum { + STM32L4x5_USART, + STM32L4x5_UART, + STM32L4x5_LPUART, +} Stm32l4x5UsartType; + +struct Stm32l4x5UsartBaseState { SysBusDevice parent_obj; MemoryRegion mmio; @@ -46,4 +56,11 @@ struct STM32L4X5UsartState { CharBackend chr; qemu_irq irq; }; + +struct Stm32l4x5UsartBaseClass { + SysBusDeviceClass parent_class; + + Stm32l4x5UsartType type; +}; + #endif /* HW_STM32L4X5_USART_H */