| Message ID | 20240227154749.1818189-12-imammedo@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS | expand |
> On 27-Feb-2024, at 21:17, Igor Mammedov <imammedo@redhat.com> wrote: > > that will avoid double free if smbios_get_tables() is called > multiple times. > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> Maybe we can squash this with patch 10. Other than that, Reviewed-by: Ani Sinha <anisinha@redhat.com> > --- > hw/smbios/smbios.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c > index 7c28b5f748..d9ba2072b1 100644 > --- a/hw/smbios/smbios.c > +++ b/hw/smbios/smbios.c > @@ -1052,6 +1052,8 @@ void smbios_get_tables(MachineState *ms, > return; > err_exit: > g_free(smbios_tables); > + smbios_tables = NULL; > + return; > } > > static void save_opt(const char **dest, QemuOpts *opts, const char *name) > -- > 2.39.3 >
On Mon, 4 Mar 2024 19:24:06 +0530 Ani Sinha <anisinha@redhat.com> wrote: > > On 27-Feb-2024, at 21:17, Igor Mammedov <imammedo@redhat.com> wrote: > > > > that will avoid double free if smbios_get_tables() is called > > multiple times. > > > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > > Maybe we can squash this with patch 10. Ok, I'll squash it into 10/19 > Other than that, > > Reviewed-by: Ani Sinha <anisinha@redhat.com> > > > --- > > hw/smbios/smbios.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c > > index 7c28b5f748..d9ba2072b1 100644 > > --- a/hw/smbios/smbios.c > > +++ b/hw/smbios/smbios.c > > @@ -1052,6 +1052,8 @@ void smbios_get_tables(MachineState *ms, > > return; > > err_exit: > > g_free(smbios_tables); > > + smbios_tables = NULL; > > + return; > > } > > > > static void save_opt(const char **dest, QemuOpts *opts, const char *name) > > -- > > 2.39.3 > > >
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 7c28b5f748..d9ba2072b1 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -1052,6 +1052,8 @@ void smbios_get_tables(MachineState *ms, return; err_exit: g_free(smbios_tables); + smbios_tables = NULL; + return; } static void save_opt(const char **dest, QemuOpts *opts, const char *name)
that will avoid double free if smbios_get_tables() is called multiple times. Signed-off-by: Igor Mammedov <imammedo@redhat.com> --- hw/smbios/smbios.c | 2 ++ 1 file changed, 2 insertions(+)