diff mbox series

[1/5] hw/isa/meson.build: Sort alphabetically

Message ID 20240218131701.91132-2-shentey@gmail.com
State New
Headers show
Series Implement port 92 in south bridges | expand

Commit Message

Bernhard Beschow Feb. 18, 2024, 1:16 p.m. UTC 
Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file"

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/isa/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Feb. 20, 2024, 7:21 a.m. UTC | #1 
On 18/2/24 14:16, Bernhard Beschow wrote:
> Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file"
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/isa/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

$ git grep -i alphab docs/devel/build-system.rst
$

Should we document this?
Mark Cave-Ayland Feb. 21, 2024, 11:42 a.m. UTC | #2 
On 18/02/2024 13:16, Bernhard Beschow wrote:

> Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file"
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/isa/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/isa/meson.build b/hw/isa/meson.build
> index f650b39507..3219282217 100644
> --- a/hw/isa/meson.build
> +++ b/hw/isa/meson.build
> @@ -1,10 +1,10 @@
>   system_ss.add(when: 'CONFIG_APM', if_true: files('apm.c'))
> +system_ss.add(when: 'CONFIG_FDC37M81X', if_true: files('fdc37m81x-superio.c'))
>   system_ss.add(when: 'CONFIG_I82378', if_true: files('i82378.c'))
>   system_ss.add(when: 'CONFIG_ISA_BUS', if_true: files('isa-bus.c'))
>   system_ss.add(when: 'CONFIG_ISA_SUPERIO', if_true: files('isa-superio.c'))
>   system_ss.add(when: 'CONFIG_PC87312', if_true: files('pc87312.c'))
>   system_ss.add(when: 'CONFIG_PIIX', if_true: files('piix.c'))
> -system_ss.add(when: 'CONFIG_FDC37M81X', if_true: files('fdc37m81x-superio.c'))
>   system_ss.add(when: 'CONFIG_SMC37C669', if_true: files('smc37c669-superio.c'))
>   system_ss.add(when: 'CONFIG_VT82C686', if_true: files('vt82c686.c'))

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.
diff mbox series

Patch

diff --git a/hw/isa/meson.build b/hw/isa/meson.build
index f650b39507..3219282217 100644
--- a/hw/isa/meson.build
+++ b/hw/isa/meson.build
@@ -1,10 +1,10 @@ 
 system_ss.add(when: 'CONFIG_APM', if_true: files('apm.c'))
+system_ss.add(when: 'CONFIG_FDC37M81X', if_true: files('fdc37m81x-superio.c'))
 system_ss.add(when: 'CONFIG_I82378', if_true: files('i82378.c'))
 system_ss.add(when: 'CONFIG_ISA_BUS', if_true: files('isa-bus.c'))
 system_ss.add(when: 'CONFIG_ISA_SUPERIO', if_true: files('isa-superio.c'))
 system_ss.add(when: 'CONFIG_PC87312', if_true: files('pc87312.c'))
 system_ss.add(when: 'CONFIG_PIIX', if_true: files('piix.c'))
-system_ss.add(when: 'CONFIG_FDC37M81X', if_true: files('fdc37m81x-superio.c'))
 system_ss.add(when: 'CONFIG_SMC37C669', if_true: files('smc37c669-superio.c'))
 system_ss.add(when: 'CONFIG_VT82C686', if_true: files('vt82c686.c'))