diff mbox series

[v3,2/2] linux-user/elfload: check PR_GET_DUMPABLE before creating coredump

Message ID 20240120-qemu-user-dumpable-v3-2-6aa410c933f1@t-8ch.de
State New
Headers show
Series linux-user: two fixes to coredump generation | expand

Commit Message

Thomas Weißschuh Jan. 20, 2024, 9:45 p.m. UTC 
A process can opt-out of coredump creation by calling
prctl(PR_SET_DUMPABLE, 0).
linux-user passes this call from the guest through to the
operating system.
From there it can be read back again to avoid creating coredumps from
qemu-user itself if the guest chose so.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---
 linux-user/elfload.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Philippe Mathieu-Daudé Jan. 22, 2024, 11:41 a.m. UTC | #1 
On 20/1/24 22:45, Thomas Weißschuh wrote:
> A process can opt-out of coredump creation by calling
> prctl(PR_SET_DUMPABLE, 0).
> linux-user passes this call from the guest through to the
> operating system.
>  From there it can be read back again to avoid creating coredumps from
> qemu-user itself if the guest chose so.
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
> ---
>   linux-user/elfload.c | 6 ++++++
>   1 file changed, 6 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index c5968719380a..daf7ef843564 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2,6 +2,7 @@ 
 #include "qemu/osdep.h"
 #include <sys/param.h>
 
+#include <sys/prctl.h>
 #include <sys/resource.h>
 #include <sys/shm.h>
 
@@ -4667,6 +4668,11 @@  static int elf_core_dump(int signr, const CPUArchState *env)
     init_note_info(&info);
 
     errno = 0;
+
+    if (prctl(PR_GET_DUMPABLE) == 0) {
+        return 0;
+    }
+
     if (getrlimit(RLIMIT_CORE, &dumpsize) == 0 && dumpsize.rlim_cur == 0) {
         return 0;
     }