| Message ID | 20231110174104.13280-1-adiupina@astralinux.ru |
|---|---|
| State | New |
| Headers | show |
| Series | hw/display/vmware_vga: fix probably typo | expand |
On 10/11/2023 18.41, Alexandra Diupina wrote: > When calling trace_vmware_verify_rect_greater_than_bound() replace > "y" with "h" and y with h > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 02218aedb1 ("hw/display/vmware_vga: replace fprintf calls with trace events") > Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru> > --- > hw/display/vmware_vga.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c > index 7490d43881..3f26bea190 100644 > --- a/hw/display/vmware_vga.c > +++ b/hw/display/vmware_vga.c > @@ -336,8 +336,8 @@ static inline bool vmsvga_verify_rect(DisplaySurface *surface, > return false; > } > if (h > SVGA_MAX_HEIGHT) { > - trace_vmware_verify_rect_greater_than_bound(name, "y", SVGA_MAX_HEIGHT, > - y); > + trace_vmware_verify_rect_greater_than_bound(name, "h", SVGA_MAX_HEIGHT, > + h); > return false; > } > if (y + h > surface_height(surface)) { That looks like a copy-n-paste bug, indeed! Reviewed-by: Thomas Huth <thuth@redhat.com>
On 10/11/23 18:41, Alexandra Diupina wrote: > When calling trace_vmware_verify_rect_greater_than_bound() replace > "y" with "h" and y with h > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 02218aedb1 ("hw/display/vmware_vga: replace fprintf calls with trace events") > Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru> > --- > hw/display/vmware_vga.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, patch queued!
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 7490d43881..3f26bea190 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -336,8 +336,8 @@ static inline bool vmsvga_verify_rect(DisplaySurface *surface, return false; } if (h > SVGA_MAX_HEIGHT) { - trace_vmware_verify_rect_greater_than_bound(name, "y", SVGA_MAX_HEIGHT, - y); + trace_vmware_verify_rect_greater_than_bound(name, "h", SVGA_MAX_HEIGHT, + h); return false; } if (y + h > surface_height(surface)) {
When calling trace_vmware_verify_rect_greater_than_bound() replace "y" with "h" and y with h Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 02218aedb1 ("hw/display/vmware_vga: replace fprintf calls with trace events") Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru> --- hw/display/vmware_vga.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)