diff mbox series

virtio-iommu: Remove useless !sdev check in virtio_iommu_probe()

Message ID 20231109170715.259520-1-eric.auger@redhat.com
State New
Headers show
Series virtio-iommu: Remove useless !sdev check in virtio_iommu_probe() | expand

Commit Message

Eric Auger Nov. 9, 2023, 5:07 p.m. UTC 
The code already checks iommu_mr is not NULL so there is no
need to check container_of() is not NULL. Remove the check.

Fixes: CID 1523901
Fixes: 09b4c3d6a2 ("virtio-iommu: Record whether a probe request has
been issued")
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reported-by: Coverity (CID 1523901)
---
 hw/virtio/virtio-iommu.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Peter Maydell Nov. 9, 2023, 5:11 p.m. UTC | #1 
On Thu, 9 Nov 2023 at 17:07, Eric Auger <eric.auger@redhat.com> wrote:
>
> The code already checks iommu_mr is not NULL so there is no
> need to check container_of() is not NULL. Remove the check.
>
> Fixes: CID 1523901
> Fixes: 09b4c3d6a2 ("virtio-iommu: Record whether a probe request has
> been issued")
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Reported-by: Coverity (CID 1523901)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM
diff mbox series

Patch

diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index 89fb5767d1..9d463efc52 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -698,9 +698,6 @@  static int virtio_iommu_probe(VirtIOIOMMU *s,
     }
 
     sdev = container_of(iommu_mr, IOMMUDevice, iommu_mr);
-    if (!sdev) {
-        return -EINVAL;
-    }
 
     count = virtio_iommu_fill_resv_mem_prop(sdev, ep_id, buf, free);
     if (count < 0) {