| Message ID | 20231108153827.39692-4-davydov-max@yandex-team.ru |
|---|---|
| State | New |
| Headers | show |
| Series | compare machine type compat_props | expand |
Hi Maksim, On 8/11/23 16:38, Maksim Davydov wrote: > Add a supportive property to access the path to the qemu binary > > Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru> > --- > python/qemu/machine/machine.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py > index 31cb9d617d..78436403b2 100644 > --- a/python/qemu/machine/machine.py > +++ b/python/qemu/machine/machine.py > @@ -328,6 +328,11 @@ def args(self) -> List[str]: > """Returns the list of arguments given to the QEMU binary.""" > return self._args > > + @property > + def binary(self) -> str: > + """Returns path to the qemu binary""" s/qemu/QEMU/ (like 2 lines earlier). Otherwise, Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > + return self._binary > + > def _pre_launch(self) -> None: > if self._qmp_set: > if self._monitor_address is None:
On Wed, Nov 8, 2023 at 10:39 AM Maksim Davydov <davydov-max@yandex-team.ru> wrote: > > Add a supportive property to access the path to the qemu binary > > Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru> > --- > python/qemu/machine/machine.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py > index 31cb9d617d..78436403b2 100644 > --- a/python/qemu/machine/machine.py > +++ b/python/qemu/machine/machine.py > @@ -328,6 +328,11 @@ def args(self) -> List[str]: > """Returns the list of arguments given to the QEMU binary.""" > return self._args > > + @property > + def binary(self) -> str: > + """Returns path to the qemu binary""" > + return self._binary > + > def _pre_launch(self) -> None: > if self._qmp_set: > if self._monitor_address is None: > -- > 2.34.1 > > 'kay. Reviewed-by: John Snow <jsnow@redhat.com>
On 8/11/23 16:38, Maksim Davydov wrote: > Add a supportive property to access the path to the qemu binary > > Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru> > --- > python/qemu/machine/machine.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py > index 31cb9d617d..78436403b2 100644 > --- a/python/qemu/machine/machine.py > +++ b/python/qemu/machine/machine.py > @@ -328,6 +328,11 @@ def args(self) -> List[str]: > """Returns the list of arguments given to the QEMU binary.""" > return self._args > > + @property > + def binary(self) -> str: > + """Returns path to the qemu binary""" > + return self._binary > + > def _pre_launch(self) -> None: > if self._qmp_set: > if self._monitor_address is None: Better patch subject could be: "python/qemu/machine: Add method to retrieve QEMUMachine::binary field"
Thanks for reviewing! I'll change patch subject to more appropriate one and fix the docstring On 11/10/23 10:03, Philippe Mathieu-Daudé wrote: > On 8/11/23 16:38, Maksim Davydov wrote: >> Add a supportive property to access the path to the qemu binary >> >> Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru> >> --- >> python/qemu/machine/machine.py | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/python/qemu/machine/machine.py >> b/python/qemu/machine/machine.py >> index 31cb9d617d..78436403b2 100644 >> --- a/python/qemu/machine/machine.py >> +++ b/python/qemu/machine/machine.py >> @@ -328,6 +328,11 @@ def args(self) -> List[str]: >> """Returns the list of arguments given to the QEMU binary.""" >> return self._args >> + @property >> + def binary(self) -> str: >> + """Returns path to the qemu binary""" >> + return self._binary >> + >> def _pre_launch(self) -> None: >> if self._qmp_set: >> if self._monitor_address is None: > > Better patch subject could be: > "python/qemu/machine: Add method to retrieve QEMUMachine::binary field"
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index 31cb9d617d..78436403b2 100644 --- a/python/qemu/machine/machine.py +++ b/python/qemu/machine/machine.py @@ -328,6 +328,11 @@ def args(self) -> List[str]: """Returns the list of arguments given to the QEMU binary.""" return self._args + @property + def binary(self) -> str: + """Returns path to the qemu binary""" + return self._binary + def _pre_launch(self) -> None: if self._qmp_set: if self._monitor_address is None:
Add a supportive property to access the path to the qemu binary Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru> --- python/qemu/machine/machine.py | 5 +++++ 1 file changed, 5 insertions(+)