diff mbox series

MAINTANERS: Split vt82c686 out of fuloong2e

Message ID 20231005181805.8EA7475723D@zero.eik.bme.hu
State New
Headers show
Series MAINTANERS: Split vt82c686 out of fuloong2e | expand

Commit Message

BALATON Zoltan Oct. 5, 2023, 6:18 p.m. UTC
It is used by other machines not just fuloong2e so put it in a
separate section and add myself as reviewer.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
By the way, PIIX4 already has a section just above where I've added
this but some files are still listed in Malta. You may want to have a
look at that.

 MAINTAINERS | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Philippe Mathieu-Daudé Oct. 5, 2023, 6:39 p.m. UTC | #1
On 5/10/23 20:18, BALATON Zoltan wrote:
> It is used by other machines not just fuloong2e so put it in a
> separate section and add myself as reviewer.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> By the way, PIIX4 already has a section just above where I've added
> this but some files are still listed in Malta. You may want to have a
> look at that.
> 
>   MAINTAINERS | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ea91f9e804..7f0e20fde6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1307,10 +1307,7 @@ M: Philippe Mathieu-Daudé <philmd@linaro.org>
>   R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>   S: Odd Fixes
>   F: hw/mips/fuloong2e.c
> -F: hw/isa/vt82c686.c
>   F: hw/pci-host/bonito.c
> -F: hw/usb/vt82c686-uhci-pci.c
> -F: include/hw/isa/vt82c686.h
>   F: include/hw/pci-host/bonito.h
>   F: tests/avocado/machine_mips_fuloong2e.py
>   
> @@ -2462,6 +2459,14 @@ S: Maintained
>   F: hw/isa/piix4.c
>   F: include/hw/southbridge/piix.h
>   
> +VIA south bridges (VT82C686B, VT8231)
> +M: Philippe Mathieu-Daudé <philmd@linaro.org>
> +R: Jiaxun Yang <jiaxun.yang@flygoat.com>
> +R: BALATON Zoltan <balaton@eik.bme.hu>

Feel free to add yourself as maintainer if you rather.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> +F: hw/isa/vt82c686.c
> +F: hw/usb/vt82c686-uhci-pci.c
> +F: include/hw/isa/vt82c686.h
> +
>   Firmware configuration (fw_cfg)
>   M: Philippe Mathieu-Daudé <philmd@linaro.org>
>   R: Gerd Hoffmann <kraxel@redhat.com>
BALATON Zoltan Oct. 5, 2023, 7:08 p.m. UTC | #2
On Thu, 5 Oct 2023, Philippe Mathieu-Daudé wrote:
> On 5/10/23 20:18, BALATON Zoltan wrote:
>> It is used by other machines not just fuloong2e so put it in a
>> separate section and add myself as reviewer.
>> 
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> By the way, PIIX4 already has a section just above where I've added
>> this but some files are still listed in Malta. You may want to have a
>> look at that.
>>
>>   MAINTAINERS | 11 ++++++++---
>>   1 file changed, 8 insertions(+), 3 deletions(-)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ea91f9e804..7f0e20fde6 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1307,10 +1307,7 @@ M: Philippe Mathieu-Daudé <philmd@linaro.org>
>>   R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>   S: Odd Fixes
>>   F: hw/mips/fuloong2e.c
>> -F: hw/isa/vt82c686.c
>>   F: hw/pci-host/bonito.c
>> -F: hw/usb/vt82c686-uhci-pci.c
>> -F: include/hw/isa/vt82c686.h
>>   F: include/hw/pci-host/bonito.h
>>   F: tests/avocado/machine_mips_fuloong2e.py
>>   @@ -2462,6 +2459,14 @@ S: Maintained
>>   F: hw/isa/piix4.c
>>   F: include/hw/southbridge/piix.h
>>   +VIA south bridges (VT82C686B, VT8231)
>> +M: Philippe Mathieu-Daudé <philmd@linaro.org>
>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> +R: BALATON Zoltan <balaton@eik.bme.hu>
>
> Feel free to add yourself as maintainer if you rather.

I'm happy with you staying maintainer if you don't mind :-) (after all 
we'll still need you to send pull requests anyway). Just wanted to get 
cc'd on this to make sure my machines won't break.

Regards,
BALATON Zoltan

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> +F: hw/isa/vt82c686.c
>> +F: hw/usb/vt82c686-uhci-pci.c
>> +F: include/hw/isa/vt82c686.h
>> +
>>   Firmware configuration (fw_cfg)
>>   M: Philippe Mathieu-Daudé <philmd@linaro.org>
>>   R: Gerd Hoffmann <kraxel@redhat.com>
>
>
BALATON Zoltan Oct. 11, 2023, 3:32 p.m. UTC | #3
On Thu, 5 Oct 2023, Philippe Mathieu-Daudé wrote:
> On 5/10/23 20:18, BALATON Zoltan wrote:
>> It is used by other machines not just fuloong2e so put it in a
>> separate section and add myself as reviewer.

Forgot to cc qemu-trivial. I thought maybe Philippe takes this but there 
were a bunch of these in trivial and Philippe submitted another 
MAINTAINERS patch with trivial cc'd so just to make sure this isn't missed 
I'm adding trivial as well.

Regards,
BALATON Zoltan

>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> By the way, PIIX4 already has a section just above where I've added
>> this but some files are still listed in Malta. You may want to have a
>> look at that.
>>
>>   MAINTAINERS | 11 ++++++++---
>>   1 file changed, 8 insertions(+), 3 deletions(-)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ea91f9e804..7f0e20fde6 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1307,10 +1307,7 @@ M: Philippe Mathieu-Daudé <philmd@linaro.org>
>>   R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>   S: Odd Fixes
>>   F: hw/mips/fuloong2e.c
>> -F: hw/isa/vt82c686.c
>>   F: hw/pci-host/bonito.c
>> -F: hw/usb/vt82c686-uhci-pci.c
>> -F: include/hw/isa/vt82c686.h
>>   F: include/hw/pci-host/bonito.h
>>   F: tests/avocado/machine_mips_fuloong2e.py
>>   @@ -2462,6 +2459,14 @@ S: Maintained
>>   F: hw/isa/piix4.c
>>   F: include/hw/southbridge/piix.h
>>   +VIA south bridges (VT82C686B, VT8231)
>> +M: Philippe Mathieu-Daudé <philmd@linaro.org>
>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> +R: BALATON Zoltan <balaton@eik.bme.hu>
>
> Feel free to add yourself as maintainer if you rather.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> +F: hw/isa/vt82c686.c
>> +F: hw/usb/vt82c686-uhci-pci.c
>> +F: include/hw/isa/vt82c686.h
>> +
>>   Firmware configuration (fw_cfg)
>>   M: Philippe Mathieu-Daudé <philmd@linaro.org>
>>   R: Gerd Hoffmann <kraxel@redhat.com>
>
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index ea91f9e804..7f0e20fde6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1307,10 +1307,7 @@  M: Philippe Mathieu-Daudé <philmd@linaro.org>
 R: Jiaxun Yang <jiaxun.yang@flygoat.com>
 S: Odd Fixes
 F: hw/mips/fuloong2e.c
-F: hw/isa/vt82c686.c
 F: hw/pci-host/bonito.c
-F: hw/usb/vt82c686-uhci-pci.c
-F: include/hw/isa/vt82c686.h
 F: include/hw/pci-host/bonito.h
 F: tests/avocado/machine_mips_fuloong2e.py
 
@@ -2462,6 +2459,14 @@  S: Maintained
 F: hw/isa/piix4.c
 F: include/hw/southbridge/piix.h
 
+VIA south bridges (VT82C686B, VT8231)
+M: Philippe Mathieu-Daudé <philmd@linaro.org>
+R: Jiaxun Yang <jiaxun.yang@flygoat.com>
+R: BALATON Zoltan <balaton@eik.bme.hu>
+F: hw/isa/vt82c686.c
+F: hw/usb/vt82c686-uhci-pci.c
+F: include/hw/isa/vt82c686.h
+
 Firmware configuration (fw_cfg)
 M: Philippe Mathieu-Daudé <philmd@linaro.org>
 R: Gerd Hoffmann <kraxel@redhat.com>