| Message ID | 20231005135550.331657-14-vsementsov@yandex-team.ru |
|---|---|
| State | New |
| Headers | show |
| Series | iotests: use vm.cmd() | expand |
On Thu, Oct 05, 2023 at 04:55:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We don't expect failure here and need 'result' object. cmd() is better > in this case. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > tests/vm/basevm.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py > index a97e23b0ce..8aef4cff96 100644 > --- a/tests/vm/basevm.py > +++ b/tests/vm/basevm.py > @@ -312,8 +312,8 @@ def boot(self, img, extra_args=[]): > self._guest = guest > # Init console so we can start consuming the chars. > self.console_init() > - usernet_info = guest.qmp("human-monitor-command", > - command_line="info usernet").get("return") > + usernet_info = guest.cmd("human-monitor-command", > + command_line="info usernet") > self.ssh_port = get_info_usernet_hostfwd_port(usernet_info) Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index a97e23b0ce..8aef4cff96 100644 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -312,8 +312,8 @@ def boot(self, img, extra_args=[]): self._guest = guest # Init console so we can start consuming the chars. self.console_init() - usernet_info = guest.qmp("human-monitor-command", - command_line="info usernet").get("return") + usernet_info = guest.cmd("human-monitor-command", + command_line="info usernet") self.ssh_port = get_info_usernet_hostfwd_port(usernet_info) if not self.ssh_port: raise Exception("Cannot find ssh port from 'info usernet':\n%s" % \
We don't expect failure here and need 'result' object. cmd() is better in this case. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> --- tests/vm/basevm.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)