| Message ID | 20230917213803.20683-25-kariem.taha2.7@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | bsd-user: Implement freebsd process related system calls. | expand |
On Sun, Sep 17, 2023 at 10:39 PM Karim Taha <kariem.taha2.7@gmail.com> wrote: > From: Stacey Son <sson@FreeBSD.org> > > Signed-off-by: Stacey Son <sson@FreeBSD.org> > Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > --- > bsd-user/freebsd/os-proc.h | 32 ++++++++++++++++++++++++++++++++ > bsd-user/freebsd/os-syscall.c | 8 ++++++++ > 2 files changed, 40 insertions(+) > > diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h > index 8a0b6e25bb..1866f0b2d6 100644 > --- a/bsd-user/freebsd/os-proc.h > +++ b/bsd-user/freebsd/os-proc.h > @@ -123,4 +123,36 @@ static inline abi_long do_freebsd_wait6(void > *cpu_env, abi_long idtype, > return ret; > } > > +/* setloginclass(2) */ > +static inline abi_long do_freebsd_setloginclass(abi_ulong arg1) > +{ > + abi_long ret; > + void *p; > + > + p = lock_user_string(arg1); > + if (p == NULL) { > + return -TARGET_EFAULT; > + } > + ret = get_errno(setloginclass(p)); > + unlock_user(p, arg1, 0); > + > + return ret; > +} > + > +/* getloginclass(2) */ > +static inline abi_long do_freebsd_getloginclass(abi_ulong arg1, abi_ulong > arg2) > +{ > + abi_long ret; > + void *p; > + > + p = lock_user_string(arg1); > This has the same problem that I highlighted in _getlogin() has. The kernel returns a string, so we have to lock the buffer for it, not the string. Warner > + if (p == NULL) { > + return -TARGET_EFAULT; > + } > + ret = get_errno(getloginclass(p, arg2)); > + unlock_user(p, arg1, 0); > + > + return ret; > +} > + > #endif /* BSD_USER_FREEBSD_OS_PROC_H */ > diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c > index 55e68e4815..d614409e69 100644 > --- a/bsd-user/freebsd/os-syscall.c > +++ b/bsd-user/freebsd/os-syscall.c > @@ -375,6 +375,14 @@ static abi_long freebsd_syscall(void *cpu_env, int > num, abi_long arg1, > ret = do_bsd_ktrace(arg1, arg2, arg3, arg4); > break; > > + case TARGET_FREEBSD_NR_setloginclass: /* setloginclass(2) */ > + ret = do_freebsd_setloginclass(arg1); > + break; > + > + case TARGET_FREEBSD_NR_getloginclass: /* getloginclass(2) */ > + ret = do_freebsd_getloginclass(arg1, arg2); > + break; > + > case TARGET_FREEBSD_NR_utrace: /* utrace(2) */ > ret = do_bsd_utrace(arg1, arg2); > break; > -- > 2.42.0 > >
diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h index 8a0b6e25bb..1866f0b2d6 100644 --- a/bsd-user/freebsd/os-proc.h +++ b/bsd-user/freebsd/os-proc.h @@ -123,4 +123,36 @@ static inline abi_long do_freebsd_wait6(void *cpu_env, abi_long idtype, return ret; } +/* setloginclass(2) */ +static inline abi_long do_freebsd_setloginclass(abi_ulong arg1) +{ + abi_long ret; + void *p; + + p = lock_user_string(arg1); + if (p == NULL) { + return -TARGET_EFAULT; + } + ret = get_errno(setloginclass(p)); + unlock_user(p, arg1, 0); + + return ret; +} + +/* getloginclass(2) */ +static inline abi_long do_freebsd_getloginclass(abi_ulong arg1, abi_ulong arg2) +{ + abi_long ret; + void *p; + + p = lock_user_string(arg1); + if (p == NULL) { + return -TARGET_EFAULT; + } + ret = get_errno(getloginclass(p, arg2)); + unlock_user(p, arg1, 0); + + return ret; +} + #endif /* BSD_USER_FREEBSD_OS_PROC_H */ diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c index 55e68e4815..d614409e69 100644 --- a/bsd-user/freebsd/os-syscall.c +++ b/bsd-user/freebsd/os-syscall.c @@ -375,6 +375,14 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1, ret = do_bsd_ktrace(arg1, arg2, arg3, arg4); break; + case TARGET_FREEBSD_NR_setloginclass: /* setloginclass(2) */ + ret = do_freebsd_setloginclass(arg1); + break; + + case TARGET_FREEBSD_NR_getloginclass: /* getloginclass(2) */ + ret = do_freebsd_getloginclass(arg1, arg2); + break; + case TARGET_FREEBSD_NR_utrace: /* utrace(2) */ ret = do_bsd_utrace(arg1, arg2); break;