From patchwork Thu Sep 14 15:54:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1834303 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=zECJimsK; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Rmhjs3vn4z1yhn for ; Fri, 15 Sep 2023 01:55:28 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgog2-0001pp-2F; Thu, 14 Sep 2023 11:54:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgofq-0001Uz-Kl for qemu-devel@nongnu.org; Thu, 14 Sep 2023 11:54:37 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgofl-000880-VH for qemu-devel@nongnu.org; Thu, 14 Sep 2023 11:54:34 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3ff7d73a6feso12566585e9.1 for ; Thu, 14 Sep 2023 08:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694706867; x=1695311667; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ra9feMe5mpTaaSeuQ9CkHp2J2B9ZX509sNZE9U1IO4U=; b=zECJimsKG9YKKF1SMlHRbrin2hPMqtmEcoK/V7Nq+q3U7ZZ2nmBn9ScN29BPjd7O0K 0/OokFAWgkJd7NBOeOGQBUoC4Xv5BbPaJErAlvSm/yEn/iTQrlGs8dwfTpF/1TyVZJ6E yo27jHfFJLCIFx0IXJAT8EIDYP+Ll4q78kfVy/45PpdT7IpS+ulp4SRwMMiOHSrf9Bmw O/Zj1TSxDWmcQ/fUGCNzrO9kkvmphZtk8tpgLETk02hD56kD8WZ5QY5B+EQK2HHT+To2 pmc3Rqo1L0Pr0+hzwyO2nrqYE781a1UUyy7Z6kHOsfbSQI39XIn5MW24aXnAc+TS0N8t WYUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694706867; x=1695311667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ra9feMe5mpTaaSeuQ9CkHp2J2B9ZX509sNZE9U1IO4U=; b=f/jKzqD9PbRCZdHMlbjUE6idv3qtTqKnYWrqrjyOOIAA45cppwkmgPSipZYSe7kjB0 aJ3t3ESwYfNPpbF9CsN2asIeoTL9Vero4rFoF/L6vWt7X0C/xiujWxX5jUpBKnbE1MQG cquplTjz8kchth1V3GFNzH0VFpvkkAL5gIBBfGiYWak6HXoCpz+0J3fbXNoHG2v/a4cT JAVY/SEbyU5FpuH5YqV6PtCvIirOa4aDOs3ZEeGFaWksgDOmB9wArZNXly22rGC2DwAi iTlRhC46BTIc1Y5UCoO5CIlx6vZZBPhl8HdiB4HX/+AYWptaIsjAnDxE3fd60yamPB4l CgVQ== X-Gm-Message-State: AOJu0YwwfcRxarf9wlXLmi6RqvySN1dk7tbtrvUFl2CrlBqQ+UOMz1bk clhGQ6Oji7fvhOtm8seUmwCOuw== X-Google-Smtp-Source: AGHT+IGVzc8qMdBfm9gV0Wg5WFAJuJJ6GSHzrZx7LYXbH3BEVUMq5WdLJvveBVE0tMNpQbmb5yS8Qg== X-Received: by 2002:a7b:c44b:0:b0:3f7:f2d0:b904 with SMTP id l11-20020a7bc44b000000b003f7f2d0b904mr4787828wmi.8.1694706866826; Thu, 14 Sep 2023 08:54:26 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id f20-20020a7bcd14000000b003fe2b6d64c8sm5144804wmj.21.2023.09.14.08.54.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 08:54:25 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1DCB11FFC1; Thu, 14 Sep 2023 16:54:23 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Cleber Rosa , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Joel Stanley , Wainer dos Santos Moschetta , Beraldo Leal , Richard Henderson , Pavel Dovgalyuk , qemu-arm@nongnu.org, Thomas Huth , Jiaxun Yang , John Snow , Mark Cave-Ayland , Peter Maydell , Laurent Vivier , Aurelien Jarno , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Markus Armbruster , Stefan Hajnoczi Subject: [PATCH 6/9] gitlab: make Cirrus CI timeout explicit Date: Thu, 14 Sep 2023 16:54:19 +0100 Message-Id: <20230914155422.426639-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230914155422.426639-1-alex.bennee@linaro.org> References: <20230914155422.426639-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Daniel P. Berrangé On the GitLab side we're invoking the Cirrus CI job using the cirrus-run tool which speaks to the Cirrus REST API. Cirrus sometimes tasks 5-10 minutes to actually schedule the task, and thus the execution time of 'cirrus-run' inside GitLab will be slightly longer than the execution time of the Cirrus CI task. Setting the timeout in the GitLab CI job should thus be done in relation to the timeout set for the Cirrus CI job. While Cirrus CI defaults to 60 minutes, it is better to set this explicitly, and make the relationship between the jobs explicit Signed-off-by: "Daniel P. Berrangé" Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Message-Id: <20230912184130.3056054-4-berrange@redhat.com> Signed-off-by: Alex Bennée --- .gitlab-ci.d/cirrus.yml | 3 +++ .gitlab-ci.d/cirrus/build.yml | 2 ++ 2 files changed, 5 insertions(+) diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml index 41d64d6680..816d89cc2a 100644 --- a/.gitlab-ci.d/cirrus.yml +++ b/.gitlab-ci.d/cirrus.yml @@ -15,6 +15,9 @@ stage: build image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master needs: [] + # 20 mins larger than "timeout_in" in cirrus/build.yml + # as there's often a 5-10 minute delay before Cirrus CI + # actually starts the task timeout: 80m allow_failure: true script: diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml index a9444902ec..29d55c4aa3 100644 --- a/.gitlab-ci.d/cirrus/build.yml +++ b/.gitlab-ci.d/cirrus/build.yml @@ -16,6 +16,8 @@ env: TEST_TARGETS: "@TEST_TARGETS@" build_task: + # A little shorter than GitLab timeout in ../cirrus.yml + timeout_in: 60m install_script: - @UPDATE_COMMAND@ - @INSTALL_COMMAND@ @PKGS@