diff mbox series

[3/5] file-posix: Fix zone update in I/O error path

Message ID 20230824155345.109765-4-hreitz@redhat.com
State New
Headers show
Series file-posix: Clean up and fix zoned checks | expand

Commit Message

Hanna Czenczek Aug. 24, 2023, 3:53 p.m. UTC 
We must check that zone information is present before running
update_zones_wp().

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2234374
Fixes: Coverity CID 1512459
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
---
 block/file-posix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Sam Li Aug. 24, 2023, 5:17 p.m. UTC | #1 
Hanna Czenczek <hreitz@redhat.com> 于2023年8月24日周四 23:53写道：
>
> We must check that zone information is present before running
> update_zones_wp().
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2234374
> Fixes: Coverity CID 1512459
> Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
> ---
>  block/file-posix.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Sam Li <faithilikerun@gmail.com>
diff mbox series

Patch

diff --git a/block/file-posix.c b/block/file-posix.c
index 46e22403fe..a050682e97 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -2525,7 +2525,8 @@  out:
             }
         }
     } else {
-        if (type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) {
+        if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
+            bs->bl.zoned != BLK_Z_NONE) {
             update_zones_wp(bs, s->fd, 0, 1);
         }
     }