| Message ID | 20230823051615.1297706-3-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | linux-user: Detect and report host crashes | expand |
On 23/8/23 07:16, Richard Henderson wrote: > This line is supposed to be unreachable, but if we're going to > have it at all, SIGABRT via abort() is subject to the same signal > peril that created this function in the first place. > > We can _exit immediately without peril. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > linux-user/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/linux-user/signal.c b/linux-user/signal.c index e1cd111a1b..57fbf2f58b 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -718,7 +718,7 @@ void die_with_signal(int sig) sigsuspend(&act.sa_mask); /* unreachable */ - abort(); + _exit(EXIT_FAILURE); } static G_NORETURN
This line is supposed to be unreachable, but if we're going to have it at all, SIGABRT via abort() is subject to the same signal peril that created this function in the first place. We can _exit immediately without peril. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- linux-user/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)