| Message ID | 20230823-i2c-echo-fixes-v1-1-ccc05a6028f0@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/misc: small fixes for i2c-echo | expand |
On 23/08/2023 10.14, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Add missing copyright and license notice. Also add a short description > of the device. > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > --- > hw/misc/i2c-echo.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/misc/i2c-echo.c b/hw/misc/i2c-echo.c > index 5705ab5d7349..5ae3d0817ead 100644 > --- a/hw/misc/i2c-echo.c > +++ b/hw/misc/i2c-echo.c > @@ -1,3 +1,13 @@ > +/* > + * Example I2C device using asynchronous I2C send. > + * > + * Copyright (C) 2023 Samsung Electronics Co., Ltd. All Rights Reserved. > + * > + * This work is licensed under the terms of the GNU GPL, version 2. See > + * the COPYING file in the top-level directory. That means GPL-2.0-only ? Please change this into GPL-2.0-or-later instead if possible, since according our main "LICENSE" file: "As of July 2013, contributions under version 2 of the GNU General Public License (and no later version) are only accepted for the following files or directories: bsd-user/, linux-user/, hw/vfio/, hw/xen/xen_pt*" While you're at it, I'd also appreciate a SPDX-License-Identifier line here. Thanks, Thomas
diff --git a/hw/misc/i2c-echo.c b/hw/misc/i2c-echo.c index 5705ab5d7349..5ae3d0817ead 100644 --- a/hw/misc/i2c-echo.c +++ b/hw/misc/i2c-echo.c @@ -1,3 +1,13 @@ +/* + * Example I2C device using asynchronous I2C send. + * + * Copyright (C) 2023 Samsung Electronics Co., Ltd. All Rights Reserved. + * + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + */ + #include "qemu/osdep.h" #include "qemu/timer.h" #include "qemu/main-loop.h"