From patchwork Wed Jun 28 09:24:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Jensen X-Patchwork-Id: 1800926 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=irrelevant.dk header.i=@irrelevant.dk header.a=rsa-sha256 header.s=fm1 header.b=Bnex0vNq; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=mWyMBguk; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QrbnP4jW7z20ZV for ; Wed, 28 Jun 2023 19:26:49 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qERQE-0006rl-7U; Wed, 28 Jun 2023 05:25:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qERQB-0006qS-II; Wed, 28 Jun 2023 05:25:07 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qERQ9-0001JL-9u; Wed, 28 Jun 2023 05:25:07 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8A1AE5C01EA; Wed, 28 Jun 2023 05:25:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 28 Jun 2023 05:25:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1687944304; x= 1688030704; bh=nc9Hvjg/exthUfwyl9oW072OtPhq6B/BaXkQeS2Ls+I=; b=B nex0vNq/qenAE2RYI5skwK6vNMKX2Bk+puXj5rqY8iZYJPOEx+ZoTxPv/ny9eWnX BuMBGffLnlmDS7LT493gurfd0i0QPnhc4CWHoxV4AKHe7lil/vK+uFGMdDW0PwL6 AKgQlPwJ2JrTd50Xjs3MfzrmkKzI+4XtAFH+E+ynNum6sVTe38QdIDaYrtwgK1jx FOTWNsF6kmh6ynjfenT7HXXtZCavlX5bzcbALZSCQylYZ29VewWQwQJp0k8PuWbW f25QvUq02uSXdd25/D5JRlPb98IuVKgdnQZC1bc1/Ii0+ybuD/wSZWpcznmy0pfP tzaoeQ+6Gaim9f8AvAgKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1687944304; x= 1688030704; bh=nc9Hvjg/exthUfwyl9oW072OtPhq6B/BaXkQeS2Ls+I=; b=m WyMBgukHjzVdcd+oJWvAU+5L+0rW7k8Up4GmtHZXFcFw5u7SonvzI+Wil4fgkwA2 PhGZ6G6MwJ9VrEmAd1y+HZJJNHpuVH5UCoHBzeekymbVppfqC36y/ZqNta1A3QKk cLXQyak7BQAxQ4GGq13Z2AvRdVBUi4FB+aBAQhr5O/QVNKmuh0YJMLfunhQJR2pN 8ZUJZGpT2dyyA9R9rP8OtYB2vsTNuZejyKPpxWlNGoBs4XQg9kAaGluK3G4KPSdn S/9CnP2ltbc0u1Xi+LGP7MUfkw2YqmCJUob1hHDqpGaRaG6UZwrHaU47ZM0s4Old +0eMqRbgAmoRIQ3ZYN5PQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddvgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeejgfeilefgieevheekueevheehkeefveegiefgheefgfejjeehffefgedujedu geenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehith hssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 Jun 2023 05:25:02 -0400 (EDT) From: Klaus Jensen To: qemu-devel@nongnu.org, Peter Maydell Cc: Fam Zheng , Stefan Hajnoczi , Kevin Wolf , Keith Busch , =?utf-8?q?P?= =?utf-8?q?hilippe_Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, Hanna Reitz , Klaus Jensen , Minwoo Im , Klaus Jensen Subject: [PULL 2/7] hw/nvme: consider COPY command in nvme_aio_err Date: Wed, 28 Jun 2023 11:24:56 +0200 Message-ID: <20230628092453.39602-11-its@irrelevant.dk> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230628092453.39602-9-its@irrelevant.dk> References: <20230628092453.39602-9-its@irrelevant.dk> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1035; i=k.jensen@samsung.com; h=from:subject; bh=SzPvUmf1mwaRcbQQTu9QRtcGmSDNxD8XoXG5+zbb4zI=; b=owJ4nAFtAZL+kA0DAAoBTeGvMW1PDekByyZiAGSb/GYe8JeNk/d+RclM8ACvIRty+82BulKac 0KHZbf85ecoxokBMwQAAQoAHRYhBFIoM6p14tzmokdmwE3hrzFtTw3pBQJkm/xmAAoJEE3hrzFt Tw3pZ04H/1UwsbdnxRqYd56fl6TMIBMtozx0ASK/RXz44JKznq969ysT/AAqd/RWtl9MW/YZK3Q 0xOvkIuN1Hm/AlcnmKbZ7BnXuVCjIAsR/8WbvSmV3WhJquJff3xjJlv9vLieXFekFTPonjZFYlW bCB7Gb/n5sCizTu5Y0bd9k5MiJ/+bhvbUm32eIcdM6SUD/YPupX3oX+9/YLuZlO2TJ4jO63KXQa aMQCA6wv8B5pnkFzbaJihBp2+nkuu5JNk6oa/exSvUY0IvZMCm8bt5s+zmgSKKSVhM4ijyBG9dR W5c54+9LrEajTwH9wOY9E9Vj6KVJPETnOOLRM+POWASb3OvIT55Z1LOl X-Developer-Key: i=k.jensen@samsung.com; a=openpgp; fpr=DDCA4D9C9EF931CC3468427263D56FC5E55DA838 Received-SPF: pass client-ip=66.111.4.29; envelope-from=its@irrelevant.dk; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Minwoo Im If we don't have NVME_CMD_COPY consideration in the switch statement in nvme_aio_err(), it will go to have NVME_INTERNAL_DEV_ERROR and `req->status` will be ovewritten to it. During the aio context, it might set the NVMe status field like NVME_CMD_SIZE_LIMIT, but it's overwritten in the nvme_aio_err(). Add consideration for the NVME_CMD_COPY not to overwrite the status at the end of the function. Signed-off-by: Minwoo Im Reviewed-by: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 020f37a780e0..e031c2250a84 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -1755,6 +1755,7 @@ static void nvme_aio_err(NvmeRequest *req, int ret) case NVME_CMD_WRITE: case NVME_CMD_WRITE_ZEROES: case NVME_CMD_ZONE_APPEND: + case NVME_CMD_COPY: status = NVME_WRITE_FAULT; break; default: