From patchwork Mon Jun 26 21:59:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1800207 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=y4cWEPo7; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QqhgN1Vzwz20XS for ; Tue, 27 Jun 2023 08:03:28 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDuFI-0002dp-No; Mon, 26 Jun 2023 17:59:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDuFE-0002aa-Uy for qemu-devel@nongnu.org; Mon, 26 Jun 2023 17:59:36 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDuFA-0004s9-Fs for qemu-devel@nongnu.org; Mon, 26 Jun 2023 17:59:36 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fa99742af9so13350205e9.2 for ; Mon, 26 Jun 2023 14:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687816771; x=1690408771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cCVrBcA62K9RLf5e56Guknvwd44ZoDW7Y93GujqWZjQ=; b=y4cWEPo7e4u0mgr0SUohceoPO7QQiLIHO5sWxD8mrpnSuo98WJjvCJ0ZbIlSPjk14s L3rFJNirp+f0GaoMaJOU9OJdo1k20U77/V5xJw2LJRJ/uRr+pVLh6xoZwMAnE0ND6yWt l+aVsPIjFRikBRE0jM6GPH5nhnKreYZHUDZIspWNzCMVWipYdKH+H3R3wJdSq2UpbxqJ JYZcklhmSQ5G+wLy9FoStOvIjWr+CCe/kBRQvXtfQ2JxThj4L3QSdv8cFDDHD6JFPDcD tpde7PJRL1pqp/ZU1UXQFIz0GCQlhRLJTs8X7byCrFCGEh2ObcLf6fPIQZ6IPe/Fs5lM 6pgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687816771; x=1690408771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cCVrBcA62K9RLf5e56Guknvwd44ZoDW7Y93GujqWZjQ=; b=b66xnS9VewmpiOyxSojPD86lw5IVp3YfJ1WnukqJErZXpThnJ2M8UEZD3uzdx0bziZ qk4GHqiSEdH8fEU+z89fkiXGRVIeFKLx5vDFlHeI7PrCo/0QfDB9EFAULpbLz6nrj7hE y3aDdZwOgbB+t99oJlZCVuuYa6bj/82+YN2V/17DC3lyVzC7nBm5WklMqM0u+0Fk7/oz zHnvp3JWMKzXhtm8kC/N6BPIC/vU+Dkw8PVoSD6xTCwvx9eyEzIc08nugMmDkvfOqPUX MJz/90v1l6Tb8ALn444faKLt3TlQfAsVYi2j9F/ne20HkVama9TO7sbpAWk2NhYNSLiq NtDw== X-Gm-Message-State: AC+VfDzqW1LJJNpGna35cKCbOZst1+2n4TCEeAoLkpaBQsWPe2D+3UmX 2V/L3n63Fzgkns7InO8p5sct/w== X-Google-Smtp-Source: ACHHUZ7U9v8V7yzcARQ2QzEcbSrCRvQC3r7hzO8JciyPynNOsOHF2nZ2JeuXX7oEBAQNaCS/FT7saQ== X-Received: by 2002:a7b:c399:0:b0:3fa:9590:a365 with SMTP id s25-20020a7bc399000000b003fa9590a365mr2927101wmj.17.1687816771132; Mon, 26 Jun 2023 14:59:31 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id k26-20020a7bc41a000000b003f080b2f9f4sm11751894wmi.27.2023.06.26.14.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 14:59:29 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B91EB1FFC3; Mon, 26 Jun 2023 22:59:27 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Alexander Bulekov , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Juan Quintela , Alexandre Iooss , Thomas Huth , Marcel Apfelbaum , Leif Lindholm , Riku Voipio , Peter Maydell , Paolo Bonzini , Bandan Das , Leonardo Bras , Cleber Rosa , Richard Henderson , Beraldo Leal , =?utf-8?q?Alex_Benn=C3=A9e?= , Peter Xu , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Mahmoud Mandour , Stefan Hajnoczi , Yanan Wang , Eduardo Habkost , Bin Meng , qemu-arm@nongnu.org, Wainer dos Santos Moschetta , Darren Kenny , Radoslaw Biernacki , Marcin Juszkiewicz , Qiuhao Li , Laurent Vivier Subject: [PATCH v2 08/26] tests/qtests: clean-up and fix leak in generic_fuzz Date: Mon, 26 Jun 2023 22:59:08 +0100 Message-Id: <20230626215926.2522656-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626215926.2522656-1-alex.bennee@linaro.org> References: <20230626215926.2522656-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org An update to the clang tooling detects more issues with the code including a memory leak from the g_string_new() allocation. Clean up the code with g_autoptr and use ARRAY_SIZE while we are at it. Signed-off-by: Alex Bennée Reviewed-by: Juan Quintela Reviewed-by: Alexander Bulekov --- tests/qtest/fuzz/generic_fuzz.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c index c525d22951..a4841181cc 100644 --- a/tests/qtest/fuzz/generic_fuzz.c +++ b/tests/qtest/fuzz/generic_fuzz.c @@ -954,17 +954,14 @@ static void register_generic_fuzz_targets(void) .crossover = generic_fuzz_crossover }); - GString *name; + g_autoptr(GString) name = g_string_new(""); const generic_fuzz_config *config; - for (int i = 0; - i < sizeof(predefined_configs) / sizeof(generic_fuzz_config); - i++) { + for (int i = 0; i < ARRAY_SIZE(predefined_configs); i++) { config = predefined_configs + i; - name = g_string_new("generic-fuzz"); - g_string_append_printf(name, "-%s", config->name); + g_string_printf(name, "generic-fuzz-%s", config->name); fuzz_add_target(&(FuzzTarget){ - .name = name->str, + .name = g_strdup(name->str), .description = "Predefined generic-fuzz config.", .get_init_cmdline = generic_fuzz_predefined_config_cmdline, .pre_fuzz = generic_pre_fuzz,