diff mbox series

[2/2] hw/mips/loongson3_virt: Remove CPU restrictions for TCG

Message ID 20230521214832.20145-3-jiaxun.yang@flygoat.com
State New
Headers show
Series MIPS: Enable Loongson-3A4000 TCG for system emulation | expand

Commit Message

Jiaxun Yang May 21, 2023, 9:48 p.m. UTC 
After implemented CPUCFG and CSR, we are now able to boot Linux
kernel with Loongson-3A4000 CPU, so there is no point to restrict
CPU type for TCG.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 hw/mips/loongson3_virt.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Philippe Mathieu-Daudé May 22, 2023, 6:03 a.m. UTC | #1 
On 21/5/23 23:48, Jiaxun Yang wrote:
> After implemented CPUCFG and CSR, we are now able to boot Linux
> kernel with Loongson-3A4000 CPU, so there is no point to restrict
> CPU type for TCG.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   hw/mips/loongson3_virt.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c
> index a57245012598..47289fb6bf85 100644
> --- a/hw/mips/loongson3_virt.c
> +++ b/hw/mips/loongson3_virt.c
> @@ -488,10 +488,6 @@ static void mips_loongson3_virt_init(MachineState *machine)
>           if (!machine->cpu_type) {
>               machine->cpu_type = MIPS_CPU_TYPE_NAME("Loongson-3A1000");
>           }
> -        if (!strstr(machine->cpu_type, "Loongson-3A1000")) {
> -            error_report("Loongson-3/TCG needs cpu type Loongson-3A1000");

Hmm, shouldn't we check for CPUs supporting the INSN_LOONGSON3A
insn_flags at least?

> -            exit(1);
> -        }
>       } else {
>           if (!machine->cpu_type) {
>               machine->cpu_type = MIPS_CPU_TYPE_NAME("Loongson-3A4000");
Philippe Mathieu-Daudé May 22, 2023, 12:08 p.m. UTC | #2 
On 21/5/23 23:48, Jiaxun Yang wrote:
> After implemented CPUCFG and CSR, we are now able to boot Linux
> kernel with Loongson-3A4000 CPU, so there is no point to restrict
> CPU type for TCG.
> 

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1639
?

> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   hw/mips/loongson3_virt.c | 4 ----
>   1 file changed, 4 deletions(-)
Jiaxun Yang May 22, 2023, 12:43 p.m. UTC | #3 
> 2023年5月22日 13:08，Philippe Mathieu-Daudé <philmd@linaro.org> 写道：
> 
> On 21/5/23 23:48, Jiaxun Yang wrote:
>> After implemented CPUCFG and CSR, we are now able to boot Linux
>> kernel with Loongson-3A4000 CPU, so there is no point to restrict
>> CPU type for TCG.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1639
> ?

Potentially yes, although I think the issue itself is just a question on usage
of the board.

Thanks
- Jiaxun

> 
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>  hw/mips/loongson3_virt.c | 4 ----
>>  1 file changed, 4 deletions(-)
> 
>
diff mbox series

Patch

diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c
index a57245012598..47289fb6bf85 100644
--- a/hw/mips/loongson3_virt.c
+++ b/hw/mips/loongson3_virt.c
@@ -488,10 +488,6 @@  static void mips_loongson3_virt_init(MachineState *machine)
         if (!machine->cpu_type) {
             machine->cpu_type = MIPS_CPU_TYPE_NAME("Loongson-3A1000");
         }
-        if (!strstr(machine->cpu_type, "Loongson-3A1000")) {
-            error_report("Loongson-3/TCG needs cpu type Loongson-3A1000");
-            exit(1);
-        }
     } else {
         if (!machine->cpu_type) {
             machine->cpu_type = MIPS_CPU_TYPE_NAME("Loongson-3A4000");