Message ID | 20230504113841.23130-3-quintela@redhat.com |
---|---|
State | New |
Headers | show |
Series | QEMU file cleanups | expand |
On Thu, May 04, 2023 at 01:38:34PM +0200, Juan Quintela wrote: > So delta_bytes can only be greater or equal to zero. Never negative. > > Signed-off-by: Juan Quintela <quintela@redhat.com> > --- > migration/block.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
diff --git a/migration/block.c b/migration/block.c index 6d532ac7a2..3499f75e37 100644 --- a/migration/block.c +++ b/migration/block.c @@ -801,13 +801,7 @@ static int block_save_iterate(QEMUFile *f, void *opaque) qemu_put_be64(f, BLK_MIG_FLAG_EOS); delta_bytes = qemu_file_total_transferred(f) - last_bytes; - if (delta_bytes > 0) { - return 1; - } else if (delta_bytes < 0) { - return -1; - } else { - return 0; - } + return (delta_bytes > 0); } /* Called with iothread lock taken. */
So delta_bytes can only be greater or equal to zero. Never negative. Signed-off-by: Juan Quintela <quintela@redhat.com> --- migration/block.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)