Message ID | 20230504081351.125140-1-thuth@redhat.com |
---|---|
State | New |
Headers | show |
Series | include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API | expand |
On Thu, May 04, 2023 at 10:13:51AM +0200, Thomas Huth wrote: > Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned > compatibility with Windows older than 8 - we should reflect this > in our _WIN32_WINNT and set it to the value that corresponds to > Windows 8. Reference for this claim: https://learn.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-170 [quote] #define _WIN32_WINNT_WIN8 0x0602 // Windows 8 [/quote] > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > include/qemu/osdep.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index 9eff0be95b..cc61b00ba9 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -75,7 +75,7 @@ QEMU_EXTERN_C int daemon(int, int); > #ifdef _WIN32 > /* as defined in sdkddkver.h */ > #ifndef _WIN32_WINNT > -#define _WIN32_WINNT 0x0601 /* Windows 7 API (should be in sync with glib) */ > +#define _WIN32_WINNT 0x0602 /* Windows 8 API (should be >= the one from glib) */ > #endif > /* reduces the number of implicitly included headers */ > #ifndef WIN32_LEAN_AND_MEAN > -- > 2.31.1 > With regards, Daniel
On 2023/05/04 17:13, Thomas Huth wrote: > Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned > compatibility with Windows older than 8 - we should reflect this > in our _WIN32_WINNT and set it to the value that corresponds to > Windows 8. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
On 5/4/23 10:13, Thomas Huth wrote: > Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned > compatibility with Windows older than 8 - we should reflect this > in our _WIN32_WINNT and set it to the value that corresponds to > Windows 8. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > include/qemu/osdep.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index 9eff0be95b..cc61b00ba9 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -75,7 +75,7 @@ QEMU_EXTERN_C int daemon(int, int); > #ifdef _WIN32 > /* as defined in sdkddkver.h */ > #ifndef _WIN32_WINNT > -#define _WIN32_WINNT 0x0601 /* Windows 7 API (should be in sync with glib) */ > +#define _WIN32_WINNT 0x0602 /* Windows 8 API (should be >= the one from glib) */ > #endif > /* reduces the number of implicitly included headers */ > #ifndef WIN32_LEAN_AND_MEAN Queued, thanks. Paolo
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 9eff0be95b..cc61b00ba9 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -75,7 +75,7 @@ QEMU_EXTERN_C int daemon(int, int); #ifdef _WIN32 /* as defined in sdkddkver.h */ #ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0601 /* Windows 7 API (should be in sync with glib) */ +#define _WIN32_WINNT 0x0602 /* Windows 8 API (should be >= the one from glib) */ #endif /* reduces the number of implicitly included headers */ #ifndef WIN32_LEAN_AND_MEAN
Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned compatibility with Windows older than 8 - we should reflect this in our _WIN32_WINNT and set it to the value that corresponds to Windows 8. Signed-off-by: Thomas Huth <thuth@redhat.com> --- include/qemu/osdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)