| Message ID | 20230420102619.348173-2-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qapi: allow unions to contain further unions | expand |
Daniel P. Berrangé <berrange@redhat.com> writes: > It is possible to pass --update to tests/qapi-schema/test-qapi.py > to make it update the output files on error. This is inconvenient > to achieve though when test-qapi.py is run indirectly by make/meson. > > Instead simply allow for an env variable to be set: > > $ QAPI_TEST_UPDATE= make check-qapi-schema > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qapi-schema/test-qapi.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py > index 2160cef082..d58c31f539 100755 > --- a/tests/qapi-schema/test-qapi.py > +++ b/tests/qapi-schema/test-qapi.py > @@ -206,6 +206,7 @@ def main(argv): > parser.add_argument('-d', '--dir', action='store', default='', > help="directory containing tests") > parser.add_argument('-u', '--update', action='store_true', > + default='QAPI_TEST_UPDATE' in os.environ, > help="update expected test results") > parser.add_argument('tests', nargs='*', metavar='TEST', action='store') > args = parser.parse_args() Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index 2160cef082..d58c31f539 100755 --- a/tests/qapi-schema/test-qapi.py +++ b/tests/qapi-schema/test-qapi.py @@ -206,6 +206,7 @@ def main(argv): parser.add_argument('-d', '--dir', action='store', default='', help="directory containing tests") parser.add_argument('-u', '--update', action='store_true', + default='QAPI_TEST_UPDATE' in os.environ, help="update expected test results") parser.add_argument('tests', nargs='*', metavar='TEST', action='store') args = parser.parse_args()
It is possible to pass --update to tests/qapi-schema/test-qapi.py to make it update the output files on error. This is inconvenient to achieve though when test-qapi.py is run indirectly by make/meson. Instead simply allow for an env variable to be set: $ QAPI_TEST_UPDATE= make check-qapi-schema Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/qapi-schema/test-qapi.py | 1 + 1 file changed, 1 insertion(+)