diff mbox series

hw/nvme: add comment for nvme-ns properties

Message ID 20230418002025.29232-1-minwoo.im.dev@gmail.com
State New
Headers show
Series hw/nvme: add comment for nvme-ns properties | expand

Commit Message

Minwoo Im April 18, 2023, 12:20 a.m. UTC 
From: Minwoo Im <minwoo.im@samsung.com>

Add more comments of existing properties for nvme-ns device.

Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/nvme/ctrl.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Klaus Jensen April 18, 2023, 6:51 a.m. UTC | #1 
On Apr 18 09:20, Minwoo Im wrote:
> From: Minwoo Im <minwoo.im@samsung.com>
> 
> Add more comments of existing properties for nvme-ns device.
> 
> Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>  hw/nvme/ctrl.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index 8b7be14209..87c07f5dbb 100644
> --- a/hw/nvme/ctrl.c
> +++ b/hw/nvme/ctrl.c
> @@ -43,7 +43,14 @@
>   *              subsys=<subsys_id>
>   *      -device nvme-ns,drive=<drive_id>,bus=<bus_name>,nsid=<nsid>,\
>   *              zoned=<true|false[optional]>, \
> - *              subsys=<subsys_id>,detached=<true|false[optional]>
> + *              subsys=<subsys_id>,shared=<true|false[optional]>, \
> + *              detached=<true|false[optional]>, \
> + *              zoned.zone_size=<N[optional]>, \
> + *              zoned.zone_capacity=<N[optional]>, \
> + *              zoned.descr_ext_size=<N[optional]>, \
> + *              zoned.max_active=<N[optional]>, \
> + *              zoned.max_open=<N[optional]>, \
> + *              zoned.cross_read=<true|false[optional]>
>   *
>   * Note cmb_size_mb denotes size of CMB in MB. CMB is assumed to be at
>   * offset 0 in BAR2 and supports only WDS, RDS and SQS for now. By default, the
> -- 
> 2.34.1
> 

Thanks,

Applied to nvme-next!
diff mbox series

Patch

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 8b7be14209..87c07f5dbb 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -43,7 +43,14 @@ 
  *              subsys=<subsys_id>
  *      -device nvme-ns,drive=<drive_id>,bus=<bus_name>,nsid=<nsid>,\
  *              zoned=<true|false[optional]>, \
- *              subsys=<subsys_id>,detached=<true|false[optional]>
+ *              subsys=<subsys_id>,shared=<true|false[optional]>, \
+ *              detached=<true|false[optional]>, \
+ *              zoned.zone_size=<N[optional]>, \
+ *              zoned.zone_capacity=<N[optional]>, \
+ *              zoned.descr_ext_size=<N[optional]>, \
+ *              zoned.max_active=<N[optional]>, \
+ *              zoned.max_open=<N[optional]>, \
+ *              zoned.cross_read=<true|false[optional]>
  *
  * Note cmb_size_mb denotes size of CMB in MB. CMB is assumed to be at
  * offset 0 in BAR2 and supports only WDS, RDS and SQS for now. By default, the