| Message ID | 20230411210422.24255-1-vikram.garhwal@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | [QEMU] gitlab-ci.d/crossbuilds: Drop the '--disable-tcg' configuration for xen | expand |
On 11/04/2023 23.04, Vikram Garhwal wrote: > Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the > build for aarch64 target. > > Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html > > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> > --- > .gitlab-ci.d/crossbuilds.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml > index 61b8ac86ee..6867839248 100644 > --- a/.gitlab-ci.d/crossbuilds.yml > +++ b/.gitlab-ci.d/crossbuilds.yml > @@ -186,7 +186,7 @@ cross-amd64-xen-only: > variables: > IMAGE: debian-amd64-cross > ACCEL: xen > - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm > + EXTRA_CONFIGURE_OPTS: --disable-kvm > > cross-arm64-xen-only: > extends: .cross_accel_build_job > @@ -195,4 +195,4 @@ cross-arm64-xen-only: > variables: > IMAGE: debian-arm64-cross > ACCEL: xen > - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm > + EXTRA_CONFIGURE_OPTS: --disable-kvm This patch looks wrong. I'm pretty sure we wanted to test the build without TCG here. Building with TCG enabled is already done in other jobs. So instead of removing "--disable-tcg" here the question is rather: Why does it not build with this flag anymore? Can those problems be fixed instead? Thomas
On 12/4/23 07:39, Thomas Huth wrote: > On 11/04/2023 23.04, Vikram Garhwal wrote: >> Xen is supported for aarch64 via xenpvh machine. disable-tcg option >> fails the >> build for aarch64 target. >> >> Link for xen on arm patch series: >> https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html >> >> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> >> --- >> .gitlab-ci.d/crossbuilds.yml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml >> index 61b8ac86ee..6867839248 100644 >> --- a/.gitlab-ci.d/crossbuilds.yml >> +++ b/.gitlab-ci.d/crossbuilds.yml >> @@ -186,7 +186,7 @@ cross-amd64-xen-only: >> variables: >> IMAGE: debian-amd64-cross >> ACCEL: xen >> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >> + EXTRA_CONFIGURE_OPTS: --disable-kvm >> cross-arm64-xen-only: >> extends: .cross_accel_build_job >> @@ -195,4 +195,4 @@ cross-arm64-xen-only: >> variables: >> IMAGE: debian-arm64-cross >> ACCEL: xen >> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >> + EXTRA_CONFIGURE_OPTS: --disable-kvm > > This patch looks wrong. I'm pretty sure we wanted to test the build > without TCG here. Building with TCG enabled is already done in other > jobs. So instead of removing "--disable-tcg" here the question is > rather: Why does it not build with this flag anymore? Can those problems > be fixed instead? I concur, this used to work. Did this config bit-rotted? The latest /master job succeeded: https://gitlab.com/qemu-project/qemu/-/jobs/4094506462
Vikram Garhwal <vikram.garhwal@amd.com> writes: > Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the > build for aarch64 target. > > Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html > > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> > --- > .gitlab-ci.d/crossbuilds.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml > index 61b8ac86ee..6867839248 100644 > --- a/.gitlab-ci.d/crossbuilds.yml > +++ b/.gitlab-ci.d/crossbuilds.yml > @@ -186,7 +186,7 @@ cross-amd64-xen-only: > variables: > IMAGE: debian-amd64-cross > ACCEL: xen > - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm > + EXTRA_CONFIGURE_OPTS: --disable-kvm x86 should handle --disable-tcg fine. > > cross-arm64-xen-only: > extends: .cross_accel_build_job > @@ -195,4 +195,4 @@ cross-arm64-xen-only: > variables: > IMAGE: debian-arm64-cross > ACCEL: xen > - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm > + EXTRA_CONFIGURE_OPTS: --disable-kvm Currently this builds qemu-system-i386, but with your changes and the work Fabiano is doing: Message-Id: <20230313151058.19645-1-farosas@suse.de> Date: Mon, 13 Mar 2023 12:10:48 -0300 Subject: [PATCH v9 00/10] target/arm: Allow CONFIG_TCG=n builds From: Fabiano Rosas <farosas@suse.de> We should be able to have a qemu-system-aarch64 supporting Xen without TCG
Alex Bennée <alex.bennee@linaro.org> writes: > Vikram Garhwal <vikram.garhwal@amd.com> writes: > >> Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the >> build for aarch64 target. >> >> Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html >> >> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> >> --- >> .gitlab-ci.d/crossbuilds.yml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml >> index 61b8ac86ee..6867839248 100644 >> --- a/.gitlab-ci.d/crossbuilds.yml >> +++ b/.gitlab-ci.d/crossbuilds.yml >> @@ -186,7 +186,7 @@ cross-amd64-xen-only: >> variables: >> IMAGE: debian-amd64-cross >> ACCEL: xen >> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >> + EXTRA_CONFIGURE_OPTS: --disable-kvm > > x86 should handle --disable-tcg fine. > >> >> cross-arm64-xen-only: >> extends: .cross_accel_build_job >> @@ -195,4 +195,4 @@ cross-arm64-xen-only: >> variables: >> IMAGE: debian-arm64-cross >> ACCEL: xen >> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >> + EXTRA_CONFIGURE_OPTS: --disable-kvm > > Currently this builds qemu-system-i386, but with your changes and the > work Fabiano is doing: > > Message-Id: <20230313151058.19645-1-farosas@suse.de> > Date: Mon, 13 Mar 2023 12:10:48 -0300 > Subject: [PATCH v9 00/10] target/arm: Allow CONFIG_TCG=n builds > From: Fabiano Rosas <farosas@suse.de> > > We should be able to have a qemu-system-aarch64 supporting Xen without TCG The build should already be working on current master after Philippe fixed the gdbstub issues. My remaining patches fix tests and general runtime issues. I just sent v10 to the list.
Hi all, Yes, gdbstub build issue is only for for aarch64-softmmu target and that was the reason for this patch. x86 targets build fine with ''disable-tcg" option. Thanks Fabiano & Philippe for sharing the existing patch series for this. Regards, Vikram On 4/12/23 5:51 AM, Fabiano Rosas wrote: > Alex Bennée <alex.bennee@linaro.org> writes: > >> Vikram Garhwal <vikram.garhwal@amd.com> writes: >> >>> Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the >>> build for aarch64 target. >>> >>> Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html >>> >>> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> >>> --- >>> .gitlab-ci.d/crossbuilds.yml | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml >>> index 61b8ac86ee..6867839248 100644 >>> --- a/.gitlab-ci.d/crossbuilds.yml >>> +++ b/.gitlab-ci.d/crossbuilds.yml >>> @@ -186,7 +186,7 @@ cross-amd64-xen-only: >>> variables: >>> IMAGE: debian-amd64-cross >>> ACCEL: xen >>> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >>> + EXTRA_CONFIGURE_OPTS: --disable-kvm >> x86 should handle --disable-tcg fine. >> >>> >>> cross-arm64-xen-only: >>> extends: .cross_accel_build_job >>> @@ -195,4 +195,4 @@ cross-arm64-xen-only: >>> variables: >>> IMAGE: debian-arm64-cross >>> ACCEL: xen >>> - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm >>> + EXTRA_CONFIGURE_OPTS: --disable-kvm >> Currently this builds qemu-system-i386, but with your changes and the >> work Fabiano is doing: >> >> Message-Id: <20230313151058.19645-1-farosas@suse.de> >> Date: Mon, 13 Mar 2023 12:10:48 -0300 >> Subject: [PATCH v9 00/10] target/arm: Allow CONFIG_TCG=n builds >> From: Fabiano Rosas <farosas@suse.de> >> >> We should be able to have a qemu-system-aarch64 supporting Xen without TCG > The build should already be working on current master after Philippe > fixed the gdbstub issues. My remaining patches fix tests and general > runtime issues. I just sent v10 to the list.
diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 61b8ac86ee..6867839248 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -186,7 +186,7 @@ cross-amd64-xen-only: variables: IMAGE: debian-amd64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm cross-arm64-xen-only: extends: .cross_accel_build_job @@ -195,4 +195,4 @@ cross-arm64-xen-only: variables: IMAGE: debian-arm64-cross ACCEL: xen - EXTRA_CONFIGURE_OPTS: --disable-tcg --disable-kvm + EXTRA_CONFIGURE_OPTS: --disable-kvm
Xen is supported for aarch64 via xenpvh machine. disable-tcg option fails the build for aarch64 target. Link for xen on arm patch series: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03979.html Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com> --- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)