| Message ID | 20230407153303.391121-3-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | block: remove bdrv_co_get_geometry coroutines from I/O hot path | expand |
On Fri, Apr 07, 2023 at 05:32:57PM +0200, Paolo Bonzini wrote: > Filters automatically get has_variable_length from their underlying > BlockDriverState. There is no need to mark them as variable-length > in the BlockDriver. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > block/copy-on-read.c | 1 - > block/filter-compress.c | 1 - > block/preallocate.c | 1 - > block/replication.c | 1 - > 4 files changed, 4 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/block/copy-on-read.c b/block/copy-on-read.c index cc0f848b0f10..b4d6b7efc30f 100644 --- a/block/copy-on-read.c +++ b/block/copy-on-read.c @@ -259,7 +259,6 @@ static BlockDriver bdrv_copy_on_read = { .bdrv_co_eject = cor_co_eject, .bdrv_co_lock_medium = cor_co_lock_medium, - .has_variable_length = true, .is_filter = true, }; diff --git a/block/filter-compress.c b/block/filter-compress.c index ac285f4b6657..320d9576fa1c 100644 --- a/block/filter-compress.c +++ b/block/filter-compress.c @@ -146,7 +146,6 @@ static BlockDriver bdrv_compress = { .bdrv_co_eject = compress_co_eject, .bdrv_co_lock_medium = compress_co_lock_medium, - .has_variable_length = true, .is_filter = true, }; diff --git a/block/preallocate.c b/block/preallocate.c index 71c360180945..4d821250366e 100644 --- a/block/preallocate.c +++ b/block/preallocate.c @@ -558,7 +558,6 @@ BlockDriver bdrv_preallocate_filter = { .bdrv_set_perm = preallocate_set_perm, .bdrv_child_perm = preallocate_child_perm, - .has_variable_length = true, .is_filter = true, }; diff --git a/block/replication.c b/block/replication.c index de01f9618467..ea4bf1aa8012 100644 --- a/block/replication.c +++ b/block/replication.c @@ -762,7 +762,6 @@ static BlockDriver bdrv_replication = { .is_filter = true, - .has_variable_length = true, .strong_runtime_opts = replication_strong_runtime_opts, };
Filters automatically get has_variable_length from their underlying BlockDriverState. There is no need to mark them as variable-length in the BlockDriver. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- block/copy-on-read.c | 1 - block/filter-compress.c | 1 - block/preallocate.c | 1 - block/replication.c | 1 - 4 files changed, 4 deletions(-)