| Message ID | 20230329124601.822209-1-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests/vm: use the default system python for NetBSD | expand |
On 3/29/23 14:46, Daniel P. Berrangé wrote: > Currently our NetBSD VM recipe requests instal of the python37 package > and explicitly tells QEMU to use that version of python. Since the > NetBSD base ISO was updated to version 9.3 though, the default system > python version is 3.9 which is sufficiently new for QEMU to rely on. > Rather than requesting an older python, just test against the default > system python which is what most users will have. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/vm/netbsd | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/vm/netbsd b/tests/vm/netbsd > index aa54338dfa..0b9536ca17 100755 > --- a/tests/vm/netbsd > +++ b/tests/vm/netbsd > @@ -30,7 +30,6 @@ class NetBSDVM(basevm.BaseVM): > "git-base", > "pkgconf", > "xz", > - "python37", > "ninja-build", > > # gnu tools > @@ -66,7 +65,7 @@ class NetBSDVM(basevm.BaseVM): > mkdir src build; cd src; > tar -xf /dev/rld1a; > cd ../build > - ../src/configure --python=python3.7 --disable-opengl {configure_opts}; > + ../src/configure --disable-opengl {configure_opts}; > gmake --output-sync -j{jobs} {target} {verbose}; > """ > poweroff = "/sbin/poweroff" Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
On 29/3/23 14:46, Daniel P. Berrangé wrote: > Currently our NetBSD VM recipe requests instal of the python37 package > and explicitly tells QEMU to use that version of python. Since the > NetBSD base ISO was updated to version 9.3 though, the default system > python version is 3.9 which is sufficiently new for QEMU to rely on. > Rather than requesting an older python, just test against the default > system python which is what most users will have. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/vm/netbsd | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Daniel P. Berrangé <berrange@redhat.com> writes: > Currently our NetBSD VM recipe requests instal of the python37 package > and explicitly tells QEMU to use that version of python. Since the > NetBSD base ISO was updated to version 9.3 though, the default system > python version is 3.9 which is sufficiently new for QEMU to rely on. > Rather than requesting an older python, just test against the default > system python which is what most users will have. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Queued to for-8.0/more-misc-fixes, thanks.
On Wed, Mar 29, 2023 at 8:47 AM Daniel P. Berrangé <berrange@redhat.com> wrote: > > Currently our NetBSD VM recipe requests instal of the python37 package > and explicitly tells QEMU to use that version of python. Since the > NetBSD base ISO was updated to version 9.3 though, the default system > python version is 3.9 which is sufficiently new for QEMU to rely on. > Rather than requesting an older python, just test against the default > system python which is what most users will have. Is this the default Python, or does it just happen to be the python that one of our other dependencies claims to require? From my notes on the mkvenv.py work, I had actually changed this over to requiring Python 3.10, because it appeared at the time that NetBSD only shipped pip for 3.10. e.g. https://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/index-all.html you can see here we've got "py310-pip" but I don't see "py39-pip". The only other pip I see is py27-pip. The impression I got was: 1) There's no such thing as a "default" python for NetBSD, 2) The best Python to use on this platform is currently 3.10. I'm not very familiar with NetBSD though, so it's definitely possible I misunderstood something. --js > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/vm/netbsd | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/vm/netbsd b/tests/vm/netbsd > index aa54338dfa..0b9536ca17 100755 > --- a/tests/vm/netbsd > +++ b/tests/vm/netbsd > @@ -30,7 +30,6 @@ class NetBSDVM(basevm.BaseVM): > "git-base", > "pkgconf", > "xz", > - "python37", > "ninja-build", > > # gnu tools > @@ -66,7 +65,7 @@ class NetBSDVM(basevm.BaseVM): > mkdir src build; cd src; > tar -xf /dev/rld1a; > cd ../build > - ../src/configure --python=python3.7 --disable-opengl {configure_opts}; > + ../src/configure --disable-opengl {configure_opts}; > gmake --output-sync -j{jobs} {target} {verbose}; > """ > poweroff = "/sbin/poweroff" > -- > 2.39.1 > >
diff --git a/tests/vm/netbsd b/tests/vm/netbsd index aa54338dfa..0b9536ca17 100755 --- a/tests/vm/netbsd +++ b/tests/vm/netbsd @@ -30,7 +30,6 @@ class NetBSDVM(basevm.BaseVM): "git-base", "pkgconf", "xz", - "python37", "ninja-build", # gnu tools @@ -66,7 +65,7 @@ class NetBSDVM(basevm.BaseVM): mkdir src build; cd src; tar -xf /dev/rld1a; cd ../build - ../src/configure --python=python3.7 --disable-opengl {configure_opts}; + ../src/configure --disable-opengl {configure_opts}; gmake --output-sync -j{jobs} {target} {verbose}; """ poweroff = "/sbin/poweroff"
Currently our NetBSD VM recipe requests instal of the python37 package and explicitly tells QEMU to use that version of python. Since the NetBSD base ISO was updated to version 9.3 though, the default system python version is 3.9 which is sufficiently new for QEMU to rely on. Rather than requesting an older python, just test against the default system python which is what most users will have. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/vm/netbsd | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)