| Message ID | 20230307183503.2512684-3-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | tcg: Remove tcg_const_* | expand |
On 7/3/23 19:34, Richard Henderson wrote: > While this enumerator has been present since the first commit, > it isn't ever used. The first actual use of round-to-odd came > with SVE, which currently uses float_round_to_odd instead of > the arm-specific enumerator. > > Amusingly, the comment about unhandled TIEAWAY has been > out of date since the initial commit of translate-a64.c. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > Cc: qemu-arm@nongnu.org > --- > target/arm/vfp_helper.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c index 24e3d820a5..90cc324f71 100644 --- a/target/arm/vfp_helper.c +++ b/target/arm/vfp_helper.c @@ -1111,10 +1111,8 @@ int arm_rmode_to_sf(int rmode) rmode = float_round_ties_away; break; case FPROUNDING_ODD: - /* FIXME: add support for TIEAWAY and ODD */ - qemu_log_mask(LOG_UNIMP, "arm: unimplemented rounding mode: %d\n", - rmode); - /* fall through for now */ + rmode = float_round_to_odd; + break; case FPROUNDING_TIEEVEN: default: rmode = float_round_nearest_even;
While this enumerator has been present since the first commit, it isn't ever used. The first actual use of round-to-odd came with SVE, which currently uses float_round_to_odd instead of the arm-specific enumerator. Amusingly, the comment about unhandled TIEAWAY has been out of date since the initial commit of translate-a64.c. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- Cc: qemu-arm@nongnu.org --- target/arm/vfp_helper.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)