From patchwork Wed Mar 1 18:23:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Warner Losh X-Patchwork-Id: 1750189 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bsdimp-com.20210112.gappssmtp.com header.i=@bsdimp-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=BVPpqWym; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PRjPW4vj8z240n for ; Thu, 2 Mar 2023 05:26:55 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXR7d-0005Lh-9t; Wed, 01 Mar 2023 13:24:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXR7b-0005E2-8G for qemu-devel@nongnu.org; Wed, 01 Mar 2023 13:24:11 -0500 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXR7Y-0006nX-EH for qemu-devel@nongnu.org; Wed, 01 Mar 2023 13:24:10 -0500 Received: by mail-io1-xd2d.google.com with SMTP id bf15so5741158iob.7 for ; Wed, 01 Mar 2023 10:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; t=1677695047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v82U4AeojucC3DQqhT5F05E7FmGdLYXG/H9YwykhwGc=; b=BVPpqWymWuk7edRXDORaOk2vs6tNZiJMrtX/Se4knI/eVtf2/voz35B/52cyu9vkuL RaMS06ToE9pxnCEXHvCTT1ui0qqQL0RgZAakkE7xq6333u0v0miEuxL2zm27KWow9652 0Dl9DVNtU6taZA4Iggrv2aLEHkFgCKD7YCj3tSLFzzVkvhY1OWjCbRYSKXotSqwlgi4h iFQE+kWqCD/gm3VDzmVJSgabh/I3nWKuNeZbKGcl66HqML7R9ac4sNCAQSFJhq6XoTKj ZiSgZvLyy/IdTQ2QTj2xOkn84ttDaAL0o5uiGEh0Q0hOS23IIOA2qvDnppVfjHUWMqmw xFcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677695047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v82U4AeojucC3DQqhT5F05E7FmGdLYXG/H9YwykhwGc=; b=LKG9Ns/xmHOAnjFiku1Gk9JiBm9oc9jojzJmAet1eguH2gI6Qi0VeGqxisFnnMPUm9 JmVblnWRvmZuWgG44AlOghGoPjhw6be0agcayJ7SYTgrhBmswuTbaaasM0xtrzqTBNlK 0ny3VnsYnFKUCoKO96QkYLu6HFowODZ/0H7GPBk14lCFa2cZZHrTNjY/Io+EHhG0fUn5 3tnVn8gX1bO7iUDE5hl6DBTC7sN7XDmYwP9UfIo7wy2meMlrxjo7W8SakSQfl5QjnjwG GSq/ZQVPFVVqyjI9uJk7pCP9p60uGKomzhrRtmNLdO+MJqbaNAMDA0f3ErROhx1IltmC 7ieQ== X-Gm-Message-State: AO0yUKVaq0OR1amVkiejbDbKcqo2lzJBjYMOaXx9WXbrFYkCIaINRh5C nEP/1MeREH8r4Uz5lXhjdcXuSu/uIZPsOTwl X-Google-Smtp-Source: AK7set+FzNdJv5JwGAzX1XctpnvYm69KK8GR+mKA+cyMaCzJoMejfTtnAXwSpzj9bFuTmIhnoFTuUg== X-Received: by 2002:a5e:8e07:0:b0:704:b905:e652 with SMTP id a7-20020a5e8e07000000b00704b905e652mr5470906ion.11.1677695046808; Wed, 01 Mar 2023 10:24:06 -0800 (PST) Received: from dune.bsdimp.com (c-71-237-47-177.hsd1.co.comcast.net. [71.237.47.177]) by smtp.gmail.com with ESMTPSA id l5-20020a6b7b05000000b0073f8a470bacsm4169316iop.16.2023.03.01.10.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 10:24:06 -0800 (PST) From: Warner Losh To: qemu-devel@nongnu.org Cc: Kyle Evans , Warner Losh , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, f4bug@amsat.org, Paolo Bonzini , Doug Rabson Subject: [PULL 01/10] bsd-user: Don't truncate the return value from freebsd_syscall Date: Wed, 1 Mar 2023 11:23:44 -0700 Message-Id: <20230301182353.21559-2-imp@bsdimp.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230301182353.21559-1-imp@bsdimp.com> References: <20230301182353.21559-1-imp@bsdimp.com> MIME-Version: 1.0 Received-SPF: none client-ip=2607:f8b0:4864:20::d2d; envelope-from=imp@bsdimp.com; helo=mail-io1-xd2d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Doug Rabson System call return values on FreeBSD are in a register (which is spelled abi_long in qemu). This was being assigned into an int variable which causes problems for 64bit targets. Resolves: https://github.com/qemu-bsd-user/qemu-bsd-user/issues/40 Signed-off-by: Doug Rabson Reviewed-by: Warner Losh [ Edited commit message for upstreaming into qemu-project ] Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/freebsd/os-syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c index 57996cad8ae..b4a663fc021 100644 --- a/bsd-user/freebsd/os-syscall.c +++ b/bsd-user/freebsd/os-syscall.c @@ -512,7 +512,7 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, abi_long arg1, abi_long arg8) { CPUState *cpu = env_cpu(cpu_env); - int ret; + abi_long ret; trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8); if (do_strace) {