diff mbox series

[v3,15/16] os-posix: remove useless ioctlsocket() define

Message ID 20230221124802.4103554-16-marcandre.lureau@redhat.com
State New
Headers show
Series win32: do not mix SOCKET and fd space | expand

Commit Message

Marc-André Lureau Feb. 21, 2023, 12:48 p.m. UTC
From: Marc-André Lureau <marcandre.lureau@redhat.com>

The API is specific to win32.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
 include/sysemu/os-posix.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Paolo Bonzini Feb. 21, 2023, 2:16 p.m. UTC | #1
On 2/21/23 13:48, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The API is specific to win32.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

The idea was to use for socket ioctls that are common to POSIX and 
Windows, but it turns out there's no such usecase.

Paolo

> ---
>   include/sysemu/os-posix.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
> index 58de7c994d..378213fc86 100644
> --- a/include/sysemu/os-posix.h
> +++ b/include/sysemu/os-posix.h
> @@ -52,7 +52,6 @@ void os_setup_post(void);
>   int os_mlock(void);
>   
>   #define closesocket(s) close(s)
> -#define ioctlsocket(s, r, v) ioctl(s, r, v)
>   
>   int os_set_daemonize(bool d);
>   bool is_daemonized(void);
diff mbox series

Patch

diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index 58de7c994d..378213fc86 100644
--- a/include/sysemu/os-posix.h
+++ b/include/sysemu/os-posix.h
@@ -52,7 +52,6 @@  void os_setup_post(void);
 int os_mlock(void);
 
 #define closesocket(s) close(s)
-#define ioctlsocket(s, r, v) ioctl(s, r, v)
 
 int os_set_daemonize(bool d);
 bool is_daemonized(void);