| Message ID | 20230217141832.24777-2-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/timer: Reduce 'hw/ptimer.h' inclusion | expand |
On 2/17/23 04:18, Philippe Mathieu-Daudé wrote: > Following the recommendation added in commit a98c370c46 > ("typedefs: (Re-)sort entries alphabetically"), and similarly > to commit 64baadc272 ("Sort include/qemu/typedefs.h"), sort > again the type definitions (in case-insensitive alphabetical > order, using 'sort --ignore-case'). > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > include/qemu/typedefs.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Am 17. Februar 2023 14:18:31 UTC schrieb "Philippe Mathieu-Daudé" <philmd@linaro.org>: >Following the recommendation added in commit a98c370c46 >("typedefs: (Re-)sort entries alphabetically"), and similarly >to commit 64baadc272 ("Sort include/qemu/typedefs.h"), sort >again the type definitions (in case-insensitive alphabetical >order, using 'sort --ignore-case'). Since it can be done mechanically: Maybe add a checkpach check? > >Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >--- > include/qemu/typedefs.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h >index c7c8a85315..df4b55ac65 100644 >--- a/include/qemu/typedefs.h >+++ b/include/qemu/typedefs.h >@@ -49,6 +49,7 @@ typedef struct DeviceState DeviceState; > typedef struct DirtyBitmapSnapshot DirtyBitmapSnapshot; > typedef struct DisplayChangeListener DisplayChangeListener; > typedef struct DriveInfo DriveInfo; >+typedef struct DumpState DumpState; > typedef struct Error Error; > typedef struct EventNotifier EventNotifier; > typedef struct FlatView FlatView; >@@ -56,6 +57,7 @@ typedef struct FWCfgEntry FWCfgEntry; > typedef struct FWCfgIoState FWCfgIoState; > typedef struct FWCfgMemState FWCfgMemState; > typedef struct FWCfgState FWCfgState; >+typedef struct GraphicHwOps GraphicHwOps; > typedef struct HostMemoryBackend HostMemoryBackend; > typedef struct I2CBus I2CBus; > typedef struct I2SCodec I2SCodec; >@@ -90,10 +92,10 @@ typedef struct PCIDevice PCIDevice; > typedef struct PCIEAERErr PCIEAERErr; > typedef struct PCIEAERLog PCIEAERLog; > typedef struct PCIEAERMsg PCIEAERMsg; >-typedef struct PCIESriovPF PCIESriovPF; >-typedef struct PCIESriovVF PCIESriovVF; > typedef struct PCIEPort PCIEPort; > typedef struct PCIESlot PCIESlot; >+typedef struct PCIESriovPF PCIESriovPF; >+typedef struct PCIESriovVF PCIESriovVF; > typedef struct PCIExpressDevice PCIExpressDevice; > typedef struct PCIExpressHost PCIExpressHost; > typedef struct PCIHostDeviceAddress PCIHostDeviceAddress; >@@ -106,6 +108,7 @@ typedef struct QBool QBool; > typedef struct QDict QDict; > typedef struct QEMUBH QEMUBH; > typedef struct QemuConsole QemuConsole; >+typedef struct QEMUCursor QEMUCursor; > typedef struct QEMUFile QEMUFile; > typedef struct QemuLockable QemuLockable; > typedef struct QemuMutex QemuMutex; >@@ -132,9 +135,6 @@ typedef struct VirtIODevice VirtIODevice; > typedef struct Visitor Visitor; > typedef struct VMChangeStateEntry VMChangeStateEntry; > typedef struct VMStateDescription VMStateDescription; >-typedef struct DumpState DumpState; >-typedef struct GraphicHwOps GraphicHwOps; >-typedef struct QEMUCursor QEMUCursor; > > /* > * Pointer types
On 18/2/23 01:47, Bernhard Beschow wrote: > > > Am 17. Februar 2023 14:18:31 UTC schrieb "Philippe Mathieu-Daudé" <philmd@linaro.org>: >> Following the recommendation added in commit a98c370c46 >> ("typedefs: (Re-)sort entries alphabetically"), and similarly >> to commit 64baadc272 ("Sort include/qemu/typedefs.h"), sort >> again the type definitions (in case-insensitive alphabetical >> order, using 'sort --ignore-case'). > > Since it can be done mechanically: Maybe add a checkpach check? There are 2 different sections in this file, each sorted alphabetically :/
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h index c7c8a85315..df4b55ac65 100644 --- a/include/qemu/typedefs.h +++ b/include/qemu/typedefs.h @@ -49,6 +49,7 @@ typedef struct DeviceState DeviceState; typedef struct DirtyBitmapSnapshot DirtyBitmapSnapshot; typedef struct DisplayChangeListener DisplayChangeListener; typedef struct DriveInfo DriveInfo; +typedef struct DumpState DumpState; typedef struct Error Error; typedef struct EventNotifier EventNotifier; typedef struct FlatView FlatView; @@ -56,6 +57,7 @@ typedef struct FWCfgEntry FWCfgEntry; typedef struct FWCfgIoState FWCfgIoState; typedef struct FWCfgMemState FWCfgMemState; typedef struct FWCfgState FWCfgState; +typedef struct GraphicHwOps GraphicHwOps; typedef struct HostMemoryBackend HostMemoryBackend; typedef struct I2CBus I2CBus; typedef struct I2SCodec I2SCodec; @@ -90,10 +92,10 @@ typedef struct PCIDevice PCIDevice; typedef struct PCIEAERErr PCIEAERErr; typedef struct PCIEAERLog PCIEAERLog; typedef struct PCIEAERMsg PCIEAERMsg; -typedef struct PCIESriovPF PCIESriovPF; -typedef struct PCIESriovVF PCIESriovVF; typedef struct PCIEPort PCIEPort; typedef struct PCIESlot PCIESlot; +typedef struct PCIESriovPF PCIESriovPF; +typedef struct PCIESriovVF PCIESriovVF; typedef struct PCIExpressDevice PCIExpressDevice; typedef struct PCIExpressHost PCIExpressHost; typedef struct PCIHostDeviceAddress PCIHostDeviceAddress; @@ -106,6 +108,7 @@ typedef struct QBool QBool; typedef struct QDict QDict; typedef struct QEMUBH QEMUBH; typedef struct QemuConsole QemuConsole; +typedef struct QEMUCursor QEMUCursor; typedef struct QEMUFile QEMUFile; typedef struct QemuLockable QemuLockable; typedef struct QemuMutex QemuMutex; @@ -132,9 +135,6 @@ typedef struct VirtIODevice VirtIODevice; typedef struct Visitor Visitor; typedef struct VMChangeStateEntry VMChangeStateEntry; typedef struct VMStateDescription VMStateDescription; -typedef struct DumpState DumpState; -typedef struct GraphicHwOps GraphicHwOps; -typedef struct QEMUCursor QEMUCursor; /* * Pointer types
Following the recommendation added in commit a98c370c46 ("typedefs: (Re-)sort entries alphabetically"), and similarly to commit 64baadc272 ("Sort include/qemu/typedefs.h"), sort again the type definitions (in case-insensitive alphabetical order, using 'sort --ignore-case'). Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/qemu/typedefs.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)