diff mbox series

[qemu-web] add missing <h2> tag

Message ID 20230214122453.30179-1-pbonzini@redhat.com
State New
Headers show
Series [qemu-web] add missing <h2> tag | expand

Commit Message

Paolo Bonzini Feb. 14, 2023, 12:24 p.m. UTC
The homepage goes straight from h1 to h3, add the missing tag for use in screen readers.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 assets/css/style.css | 12 ++++++++++++
 index.html           |  3 +++
 2 files changed, 15 insertions(+)

Comments

Thomas Huth Feb. 14, 2023, 12:29 p.m. UTC | #1
On 14/02/2023 13.24, Paolo Bonzini wrote:
> The homepage goes straight from h1 to h3, add the missing tag for use in screen readers.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   assets/css/style.css | 12 ++++++++++++
>   index.html           |  3 +++
>   2 files changed, 15 insertions(+)
> 
> diff --git a/assets/css/style.css b/assets/css/style.css
> index 779b111..2705787 100644
> --- a/assets/css/style.css
> +++ b/assets/css/style.css
> @@ -44,6 +44,18 @@
>   		color: #802400;
>   	}
>   
> +        .visuallyhidden
> +	{
> +		border: 0;
> +		clip: rect(0 0 0 0);
> +		height: 1px;
> +		margin: -1px;
> +		overflow: hidden;
> +		padding: 0;
> +		position: absolute;
> +		width: 1px;
> +	}
> +
>   	pre,code,samp,tt
>   	{
>   		font-family: 'Roboto Mono', monospace;
> diff --git a/index.html b/index.html
> index d72750c..676c379 100644
> --- a/index.html
> +++ b/index.html
> @@ -14,6 +14,9 @@ colorbox: True
>   	
>   <!-- Featured -->
>   <div id="featured">
> +	<header class="visuallyhidden">
> +		<h2>Features</h2>
> +	</header>
>   	<div class="container">
>   		<div class="row">
>   			<section class="4u">

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/assets/css/style.css b/assets/css/style.css
index 779b111..2705787 100644
--- a/assets/css/style.css
+++ b/assets/css/style.css
@@ -44,6 +44,18 @@ 
 		color: #802400;
 	}
 
+        .visuallyhidden
+	{
+		border: 0;
+		clip: rect(0 0 0 0);
+		height: 1px;
+		margin: -1px;
+		overflow: hidden;
+		padding: 0;
+		position: absolute;
+		width: 1px;
+	}
+
 	pre,code,samp,tt
 	{
 		font-family: 'Roboto Mono', monospace;
diff --git a/index.html b/index.html
index d72750c..676c379 100644
--- a/index.html
+++ b/index.html
@@ -14,6 +14,9 @@  colorbox: True
 	
 <!-- Featured -->
 <div id="featured">
+	<header class="visuallyhidden">
+		<h2>Features</h2>
+	</header>
 	<div class="container">
 		<div class="row">
 			<section class="4u">