| Message ID | 20230213093625.158170-3-zhao1.liu@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Support smp.clusters for x86 | expand |
On Wed, Feb 15, 2023 at 10:36:34AM +0800, wangyanan (Y) wrote: > Date: Wed, 15 Feb 2023 10:36:34 +0800 > From: "wangyanan (Y)" <wangyanan55@huawei.com> > Subject: Re: [PATCH RESEND 02/18] tests: Rename test-x86-cpuid.c to > test-x86-apicid.c > > 在 2023/2/13 17:36, Zhao Liu 写道: > > From: Zhao Liu <zhao1.liu@intel.com> > > > > In fact, this unit tests APIC ID other than CPUID. > > Rename to test-x86-apicid.c to make its name more in line with its > > actual content. > > > > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > > --- > > MAINTAINERS | 2 +- > > tests/unit/meson.build | 4 ++-- > > tests/unit/{test-x86-cpuid.c => test-x86-apicid.c} | 2 +- > > 3 files changed, 4 insertions(+), 4 deletions(-) > > rename tests/unit/{test-x86-cpuid.c => test-x86-apicid.c} (99%) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 96e25f62acaa..71c1bc24371b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1679,7 +1679,7 @@ F: include/hw/southbridge/piix.h > > F: hw/misc/sga.c > > F: hw/isa/apm.c > > F: include/hw/isa/apm.h > > -F: tests/unit/test-x86-cpuid.c > > +F: tests/unit/test-x86-apicid.c > > F: tests/qtest/test-x86-cpuid-compat.c > > PC Chipset > > diff --git a/tests/unit/meson.build b/tests/unit/meson.build > > index ffa444f4323c..a9df2843e92e 100644 > > --- a/tests/unit/meson.build > > +++ b/tests/unit/meson.build > > @@ -20,8 +20,8 @@ tests = { > > 'test-opts-visitor': [testqapi], > > 'test-visitor-serialization': [testqapi], > > 'test-bitmap': [], > > - # all code tested by test-x86-cpuid is inside topology.h > > - 'test-x86-cpuid': [], > > + # all code tested by test-x86-apicid is inside topology.h > > + 'test-x86-apicid': [], > > 'test-cutils': [], > > 'test-div128': [], > > 'test-shift128': [], > > diff --git a/tests/unit/test-x86-cpuid.c b/tests/unit/test-x86-apicid.c > > similarity index 99% > > rename from tests/unit/test-x86-cpuid.c > > rename to tests/unit/test-x86-apicid.c > > index bfabc0403a1a..2b104f86d7c2 100644 > > --- a/tests/unit/test-x86-cpuid.c > > +++ b/tests/unit/test-x86-apicid.c > > @@ -1,5 +1,5 @@ > > /* > > - * Test code for x86 CPUID and Topology functions > > + * Test code for x86 APIC ID and Topology functions > > * > I'm not very sure. The "CPUID" sounds like a general test for kinds of CPU > IDs. CPUID usually refers to that basic instruction in the x86 to obtain basic cpu information. So such naming is prone to ambiguity. The cpu topology info of x86 is parsed based on the apic id, including the sub-ids of each topology levels (such as thread id/core id...etc.). These sub-ids are all part of the apic id. > Besides APIC IDs computed from x86_apicid_from_cpu_idx(), there are also > topo IDs computed from x86_topo_ids_from_idx() although this kind of IDs > are not tested in test-x86-cpuid.c so far. What about "test-x86-topo.c" or "test-x86-topo-ids.c"? > > Thanks, > Yanan > > * Copyright (c) 2012 Red Hat Inc. > > * >
diff --git a/MAINTAINERS b/MAINTAINERS index 96e25f62acaa..71c1bc24371b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1679,7 +1679,7 @@ F: include/hw/southbridge/piix.h F: hw/misc/sga.c F: hw/isa/apm.c F: include/hw/isa/apm.h -F: tests/unit/test-x86-cpuid.c +F: tests/unit/test-x86-apicid.c F: tests/qtest/test-x86-cpuid-compat.c PC Chipset diff --git a/tests/unit/meson.build b/tests/unit/meson.build index ffa444f4323c..a9df2843e92e 100644 --- a/tests/unit/meson.build +++ b/tests/unit/meson.build @@ -20,8 +20,8 @@ tests = { 'test-opts-visitor': [testqapi], 'test-visitor-serialization': [testqapi], 'test-bitmap': [], - # all code tested by test-x86-cpuid is inside topology.h - 'test-x86-cpuid': [], + # all code tested by test-x86-apicid is inside topology.h + 'test-x86-apicid': [], 'test-cutils': [], 'test-div128': [], 'test-shift128': [], diff --git a/tests/unit/test-x86-cpuid.c b/tests/unit/test-x86-apicid.c similarity index 99% rename from tests/unit/test-x86-cpuid.c rename to tests/unit/test-x86-apicid.c index bfabc0403a1a..2b104f86d7c2 100644 --- a/tests/unit/test-x86-cpuid.c +++ b/tests/unit/test-x86-apicid.c @@ -1,5 +1,5 @@ /* - * Test code for x86 CPUID and Topology functions + * Test code for x86 APIC ID and Topology functions * * Copyright (c) 2012 Red Hat Inc. *