| Message ID | 20230209154034.983044-6-jsnow@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Python: Drop support for Python 3.6 | expand |
On 09/02/2023 16.40, John Snow wrote: > This is just a proof-of-concept patch, as these files are lcitool > generated. The real fix will involve updating the lcitool configuration > and updating these files that way. I think it would be good to have a RFC or DONOTMERGE in the patch title, so that it is clear right from the start that this should not get merged. > Note that this requires OpenSuSE Leap 15.3; 15.2 won't cut it. Looking at https://en.wikipedia.org/wiki/OpenSUSE#Version_history it seems like even 15.3 is EOL already, so I think we can switch to 15.4 immediately. Thomas
On Thu, Feb 9, 2023 at 10:56 AM Thomas Huth <thuth@redhat.com> wrote: > > On 09/02/2023 16.40, John Snow wrote: > > This is just a proof-of-concept patch, as these files are lcitool > > generated. The real fix will involve updating the lcitool configuration > > and updating these files that way. > > I think it would be good to have a RFC or DONOTMERGE in the patch title, so > that it is clear right from the start that this should not get merged. Apologies. I just assumed there'd be no risk of this passing review :) If there's any point in me respinning this with the proof-of-concept again, I'll add a DO-NOT-MERGE tag. > > > Note that this requires OpenSuSE Leap 15.3; 15.2 won't cut it. > > Looking at https://en.wikipedia.org/wiki/OpenSUSE#Version_history it seems > like even 15.3 is EOL already, so I think we can switch to 15.4 immediately. > Noted. Some of the patches in this series are a bit old, admittedly, so I'll re-review these requirements. I'm hoping to hear from Dan/Alex on the subject of coverage, because I don't really know what our current strategy is or what our coverage ought to be. If CI minutes were infinitely free, I'd suggest we test both CentOS 8 and 9 simultaneously, alongside with every currently supported OpenSuSE version, but I imagine that's not really truly on the table. I imagine we want to have a mixture of "cutting edge" with "oldest we still support" to try and cover the spread of likely scenarios, but I am not sure what the strategies for which to keep at which versions are. > Thomas >
On Thu, Feb 09, 2023 at 10:40:32AM -0500, John Snow wrote: > This is just a proof-of-concept patch, as these files are lcitool > generated. The real fix will involve updating the lcitool configuration > and updating these files that way. Paolo has been working on this https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg03547.html though I requested we adapt it a little: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02237.html https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02239.html With regards, Daniel
On Fri, Feb 10, 2023 at 5:38 AM Daniel P. Berrangé <berrange@redhat.com> wrote: > > On Thu, Feb 09, 2023 at 10:40:32AM -0500, John Snow wrote: > > This is just a proof-of-concept patch, as these files are lcitool > > generated. The real fix will involve updating the lcitool configuration > > and updating these files that way. > > Paolo has been working on this > > https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg03547.html > > though I requested we adapt it a little: > > https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02237.html > https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg02239.html > > With regards, > Daniel Ah, I had no idea that Paolo was specifically working on 3.7 as a minimum requisite; I hadn't actually seen this or talked with him about this in some time. With this series I was mostly occupied with the simpler question of "Is this even possible?" ... I'll just trust that the lcitool changes are in good hands with Paolo. Thanks for the links to the relevant threads :~) --js
diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker index fbc953c6dcc..a3bfddf382d 100644 --- a/tests/docker/dockerfiles/centos8.docker +++ b/tests/docker/dockerfiles/centos8.docker @@ -95,6 +95,7 @@ RUN dnf distro-sync -y && \ pkgconfig \ pulseaudio-libs-devel \ python3 \ + python38 \ python3-PyYAML \ python3-numpy \ python3-pillow \ diff --git a/tests/docker/dockerfiles/opensuse-leap.docker b/tests/docker/dockerfiles/opensuse-leap.docker index 4b2c02d6abf..9e688c1d441 100644 --- a/tests/docker/dockerfiles/opensuse-leap.docker +++ b/tests/docker/dockerfiles/opensuse-leap.docker @@ -89,6 +89,7 @@ RUN zypper update -y && \ pam-devel \ pcre-devel-static \ pkgconfig \ + python39 \ python3-Pillow \ python3-PyYAML \ python3-Sphinx \
This is just a proof-of-concept patch, as these files are lcitool generated. The real fix will involve updating the lcitool configuration and updating these files that way. Note that this requires OpenSuSE Leap 15.3; 15.2 won't cut it. This is just to prove that bumping our dependency works. Signed-off-by: John Snow <jsnow@redhat.com> --- tests/docker/dockerfiles/centos8.docker | 1 + tests/docker/dockerfiles/opensuse-leap.docker | 1 + 2 files changed, 2 insertions(+)