| Message ID | 20230208171922.95048-1-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 08/02/2023 18.19, Paolo Bonzini wrote: > The following changes since commit ae2b5d8381a73b27f35f19c988d45c78bb4d5768: > > Merge tag 'pull-include-2023-02-06-v2' of https://repo.or.cz/qemu/armbru into staging (2023-02-08 10:40:06 +0000) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to e0de04cf9bd7cf03db16f33276679caf1724b75c: > > target/i386: fix ADOX followed by ADCX (2023-02-08 18:16:55 +0100) > > ---------------------------------------------------------------- > * block/iscsi: fix double-free on BUSY or similar statuses > * catch [accel] entry without accelerator > * target/i386: various fixes for BMI and ADX instructions > * make the contents of meson-buildoptions.sh stable > > ---------------------------------------------------------------- > Paolo Bonzini (8): > build: make meson-buildoptions.sh stable > remove unnecessary extern "C" blocks > block/iscsi: fix double-free on BUSY or similar statuses > vl: catch [accel] entry without accelerator You missed Philippe's review comment for that patch: https://lore.kernel.org/qemu-devel/8ec3abf5-f4aa-db40-cb7e-2f5733d93de3@linaro.org/ Thomas
On 9/2/23 06:19, Thomas Huth wrote: > On 08/02/2023 18.19, Paolo Bonzini wrote: >> The following changes since commit >> ae2b5d8381a73b27f35f19c988d45c78bb4d5768: >> >> Merge tag 'pull-include-2023-02-06-v2' of >> https://repo.or.cz/qemu/armbru into staging (2023-02-08 10:40:06 +0000) >> >> are available in the Git repository at: >> >> https://gitlab.com/bonzini/qemu.git tags/for-upstream >> >> for you to fetch changes up to e0de04cf9bd7cf03db16f33276679caf1724b75c: >> >> target/i386: fix ADOX followed by ADCX (2023-02-08 18:16:55 +0100) >> >> ---------------------------------------------------------------- >> * block/iscsi: fix double-free on BUSY or similar statuses >> * catch [accel] entry without accelerator >> * target/i386: various fixes for BMI and ADX instructions >> * make the contents of meson-buildoptions.sh stable >> >> ---------------------------------------------------------------- >> Paolo Bonzini (8): >> build: make meson-buildoptions.sh stable >> remove unnecessary extern "C" blocks >> block/iscsi: fix double-free on BUSY or similar statuses >> vl: catch [accel] entry without accelerator > > You missed Philippe's review comment for that patch: > > https://lore.kernel.org/qemu-devel/8ec3abf5-f4aa-db40-cb7e-2f5733d93de3@linaro.org/ I interpreted "no response" as "the result is the same".
Yeah it's the same but it should use errp. Sorry to both of you! Paolo Il gio 9 feb 2023, 08:09 Philippe Mathieu-Daudé <philmd@linaro.org> ha scritto: > On 9/2/23 06:19, Thomas Huth wrote: > > On 08/02/2023 18.19, Paolo Bonzini wrote: > >> The following changes since commit > >> ae2b5d8381a73b27f35f19c988d45c78bb4d5768: > >> > >> Merge tag 'pull-include-2023-02-06-v2' of > >> https://repo.or.cz/qemu/armbru into staging (2023-02-08 10:40:06 +0000) > >> > >> are available in the Git repository at: > >> > >> https://gitlab.com/bonzini/qemu.git tags/for-upstream > >> > >> for you to fetch changes up to e0de04cf9bd7cf03db16f33276679caf1724b75c: > >> > >> target/i386: fix ADOX followed by ADCX (2023-02-08 18:16:55 +0100) > >> > >> ---------------------------------------------------------------- > >> * block/iscsi: fix double-free on BUSY or similar statuses > >> * catch [accel] entry without accelerator > >> * target/i386: various fixes for BMI and ADX instructions > >> * make the contents of meson-buildoptions.sh stable > >> > >> ---------------------------------------------------------------- > >> Paolo Bonzini (8): > >> build: make meson-buildoptions.sh stable > >> remove unnecessary extern "C" blocks > >> block/iscsi: fix double-free on BUSY or similar statuses > >> vl: catch [accel] entry without accelerator > > > > You missed Philippe's review comment for that patch: > > > > > https://lore.kernel.org/qemu-devel/8ec3abf5-f4aa-db40-cb7e-2f5733d93de3@linaro.org/ > > I interpreted "no response" as "the result is the same". > >
The following changes since commit ae2b5d8381a73b27f35f19c988d45c78bb4d5768: Merge tag 'pull-include-2023-02-06-v2' of https://repo.or.cz/qemu/armbru into staging (2023-02-08 10:40:06 +0000) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to e0de04cf9bd7cf03db16f33276679caf1724b75c: target/i386: fix ADOX followed by ADCX (2023-02-08 18:16:55 +0100) ---------------------------------------------------------------- * block/iscsi: fix double-free on BUSY or similar statuses * catch [accel] entry without accelerator * target/i386: various fixes for BMI and ADX instructions * make the contents of meson-buildoptions.sh stable ---------------------------------------------------------------- Paolo Bonzini (8): build: make meson-buildoptions.sh stable remove unnecessary extern "C" blocks block/iscsi: fix double-free on BUSY or similar statuses vl: catch [accel] entry without accelerator libqtest: split qtest_spawn_qemu function libqtest: ensure waitpid() is only called once readconfig-test: add test for accelerator configuration target/i386: fix ADOX followed by ADCX Richard Henderson (3): tests/tcg/i386: Introduce and use reg_t consistently target/i386: Fix BEXTR instruction target/i386: Fix C flag for BLSI, BLSMSK, BLSR block/iscsi.c | 1 + include/disas/dis-asm.h | 8 -- include/qemu/bswap.h | 8 -- include/qemu/envlist.h | 8 -- include/qemu/rcu.h | 8 -- include/qemu/rcu_queue.h | 8 -- include/qemu/uri.h | 7 -- scripts/meson-buildoptions.py | 7 +- scripts/meson-buildoptions.sh | 2 +- softmmu/vl.c | 15 ++- target/i386/tcg/emit.c.inc | 45 +++++---- tests/qtest/libqtest.c | 186 ++++++++++++++++++++++--------------- tests/qtest/libqtest.h | 12 +++ tests/qtest/readconfig-test.c | 45 +++++++-- tests/tcg/i386/Makefile.target | 6 +- tests/tcg/i386/test-i386-adcox.c | 75 +++++++++++++++ tests/tcg/i386/test-i386-bmi2.c | 194 +++++++++++++++++++++------------------ 17 files changed, 386 insertions(+), 249 deletions(-) create mode 100644 tests/tcg/i386/test-i386-adcox.c