diff mbox series

[v1,2/2] loongarch: Add smbios command line option.

Message ID 20230208094133.2945979-2-gaosong@loongson.cn
State New
Headers show
Series [v1,1/2] docs/system/loongarch: update loongson3.rst and rename it to virt.rst | expand

Commit Message

gaosong Feb. 8, 2023, 9:41 a.m. UTC
LoongArch has enabled CONFIG_SMBIOS, but didn't enable CLI '-smbios'.

Signed-off-by: Song Gao <gaosong@loongson.cn>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael S. Tsirkin Feb. 8, 2023, 9:51 a.m. UTC | #1
On Wed, Feb 08, 2023 at 05:41:33PM +0800, Song Gao wrote:
> LoongArch has enabled CONFIG_SMBIOS, but didn't enable CLI '-smbios'.
> 
> Signed-off-by: Song Gao <gaosong@loongson.cn>

Acked-by: Michael S. Tsirkin <mst@redhat.com>


> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 88e93c6103..2aa6709466 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2592,7 +2592,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
>      "                specify SMBIOS type 17 fields\n"
>      "-smbios type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
>      "                specify SMBIOS type 41 fields\n",
> -    QEMU_ARCH_I386 | QEMU_ARCH_ARM)
> +    QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH)
>  SRST
>  ``-smbios file=binary``
>      Load SMBIOS entry from binary file.
> -- 
> 2.31.1
Markus Armbruster Feb. 8, 2023, 10:26 a.m. UTC | #2
Song Gao <gaosong@loongson.cn> writes:

> LoongArch has enabled CONFIG_SMBIOS, but didn't enable CLI '-smbios'.
>

Suggest

  Fixes: 3efa6fa1e629 ("hw/loongarch: Add smbios support")

> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 88e93c6103..2aa6709466 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2592,7 +2592,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
>      "                specify SMBIOS type 17 fields\n"
>      "-smbios type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
>      "                specify SMBIOS type 41 fields\n",
> -    QEMU_ARCH_I386 | QEMU_ARCH_ARM)
> +    QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH)
>  SRST
>  ``-smbios file=binary``
>      Load SMBIOS entry from binary file.

Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff mbox series

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index 88e93c6103..2aa6709466 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2592,7 +2592,7 @@  DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
     "                specify SMBIOS type 17 fields\n"
     "-smbios type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
     "                specify SMBIOS type 41 fields\n",
-    QEMU_ARCH_I386 | QEMU_ARCH_ARM)
+    QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH)
 SRST
 ``-smbios file=binary``
     Load SMBIOS entry from binary file.